Date: Tue, 27 Jul 2021 15:36:05 GMT From: Ed Maste <emaste@FreeBSD.org> To: doc-committers@FreeBSD.org, dev-commits-doc-all@FreeBSD.org Subject: git: 05ace519fb - main - committers-guide: Place Differential Revision last in table Message-ID: <202107271536.16RFa5iF076315@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by emaste (src committer): URL: https://cgit.FreeBSD.org/doc/commit/?id=05ace519fbd0dc1fa759245deeef75df8ccb951b commit 05ace519fbd0dc1fa759245deeef75df8ccb951b Author: Ed Maste <emaste@FreeBSD.org> AuthorDate: 2021-07-26 16:47:26 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2021-07-27 15:35:14 +0000 committers-guide: Place Differential Revision last in table Differential Revision must be the last line of the commit message. List it last in the table as well to help make this clear. Reviewed by: imp, ygy Approved by: ygy Differential Revision: https://reviews.freebsd.org/D31309 --- documentation/content/en/articles/committers-guide/_index.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/documentation/content/en/articles/committers-guide/_index.adoc b/documentation/content/en/articles/committers-guide/_index.adoc index c0c5a4e559..83d4c490a9 100644 --- a/documentation/content/en/articles/committers-guide/_index.adoc +++ b/documentation/content/en/articles/committers-guide/_index.adoc @@ -2885,12 +2885,12 @@ Approved by: re (username) It should include the entire URL to the pull request, as these often act as code reviews for the code. For example: `https://github.com/freebsd/freebsd-src/pull/745` -|`Differential Revision:` -|The full URL of the Phabricator review. This line __must be the last line__. For example: `https://reviews.freebsd.org/D1708`. - |`Signed-off-by:` |ID certifies compliance with https://developercertificate.org/ +|`Differential Revision:` +|The full URL of the Phabricator review. This line __must be the last line__. For example: `https://reviews.freebsd.org/D1708`. + |=== .Commit Log for a Commit Based on a PR
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202107271536.16RFa5iF076315>