Date: Wed, 13 Oct 2004 08:39:08 +0200 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Hidetoshi Shimokawa <simokawa@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/dcons dcons.c dcons.h dcons_crom.c dcons_os.c dcons_os.h Message-ID: <35813.1097649548@critter.freebsd.dk> In-Reply-To: Your message of "Wed, 13 Oct 2004 05:38:42 -0000." <200410130538.i9D5cgfA074842@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This obliterated my tty patches for dcons, and after seeing the tangle of #ifdefs in dcons_os.c I'm not going anywhere near it again. My personal advice would be to have a dcons_freebsd.c and dcons_dfly.c instead of this unholy mess. Poul-Henning In message <200410130538.i9D5cgfA074842@repoman.freebsd.org>, Hidetoshi Shimoka wa writes: >simokawa 2004-10-13 05:38:42 UTC > > FreeBSD src repository > > Modified files: > sys/dev/dcons dcons.c dcons.h dcons_crom.c > Added files: > sys/dev/dcons dcons_os.c dcons_os.h > Log: > - Split dcons core code and OS dependent code. > - Implement dcons_ischar() and dcons_load_buffer(). > - If loader passed a dcons buffer address, keep using it. > (We still need a patch to cheat memory management system.) > > Revision Changes Path > 1.19 +71 -642 src/sys/dev/dcons/dcons.c > 1.3 +13 -8 src/sys/dev/dcons/dcons.h > 1.5 +9 -0 src/sys/dev/dcons/dcons_crom.c > 1.1 +746 -0 src/sys/dev/dcons/dcons_os.c (new) > 1.1 +44 -0 src/sys/dev/dcons/dcons_os.h (new) > -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?35813.1097649548>