Date: Tue, 28 Oct 2008 06:56:23 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184341 - head/usr.sbin Message-ID: <20081028065010.A2978@maildrop.int.zabbadoz.net> In-Reply-To: <200810271418.41291.jhb@freebsd.org> References: <200810271515.m9RFF86d042970@svn.freebsd.org> <200810271418.41291.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 27 Oct 2008, John Baldwin wrote: > On Monday 27 October 2008 11:15:08 am Bjoern A. Zeeb wrote: >> Author: bz >> Date: Mon Oct 27 15:15:08 2008 >> New Revision: 184341 >> URL: http://svn.freebsd.org/changeset/base/184341 >> >> Log: >> We do not have a libkse anymore and Mk/bsd.* does not know >> about LIBKSE anymore, so s,MK_LIBKSE,MK_LIBPTHREAD,. > > Shouldn't you just remove it instead? These two options are now basically > identical. (We probably should rename libthr to libpthread at some point.) tools/build/options/WITHOUT_LIBPTHREAD still talks about kse and thus does src.conf(5). I wouldn't object to removing one of the options but according to the src.conf my bet would be LIBTHR and not LIBPTHREAD. So updating the documentation might be a good initial step as well. I have to admit that I lost track about our threading libs in different branches at one time; how many are left in head - 1 or 2? Is only libthr left and we build it as libthr and add symlinks for libpthread? >> Modified: >> head/usr.sbin/Makefile >> >> Modified: head/usr.sbin/Makefile >> > ============================================================================== >> --- head/usr.sbin/Makefile Mon Oct 27 14:49:12 2008 (r184340) >> +++ head/usr.sbin/Makefile Mon Oct 27 15:15:08 2008 (r184341) >> @@ -292,7 +292,7 @@ _moused= moused >> _vidcontrol= vidcontrol >> .endif >> >> -.if ${MK_LIBTHR} != "no" || ${MK_LIBKSE} != "no" >> +.if ${MK_LIBTHR} != "no" || ${MK_LIBPTHREAD} != "no" >> .if ${MK_PPP} != "no" >> _pppctl= pppctl >> .endif >> > > > > -- Bjoern A. Zeeb Stop bit received. Insert coin for new game.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081028065010.A2978>