Date: Fri, 15 Aug 2008 13:20:03 GMT From: "Josh Carroll" <josh.carroll@gmail.com> To: freebsd-multimedia@FreeBSD.org Subject: Re: ports/126045: multimedia/ffmpeg needs --enable-nonfree with --enable-libamr* Message-ID: <200808151320.m7FDK3n8028638@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/126045; it has been noted by GNATS.
From: "Josh Carroll" <josh.carroll@gmail.com>
To: "Martin Matuska" <mm@freebsd.org>
Cc: bug-followup@freebsd.org
Subject: Re: ports/126045: multimedia/ffmpeg needs --enable-nonfree with --enable-libamr*
Date: Fri, 15 Aug 2008 09:15:11 -0400
2008/8/15 Martin Matuska <mm@freebsd.org>:
> I suggest a more elegant solution without any new OPTIONS:
>
> Index: ports/multimedia/ffmpeg/Makefile
> ===================================================================
> RCS file: /home/pcvs/ports/multimedia/ffmpeg/Makefile,v
> retrieving revision 1.87
> diff -u -r1.87 Makefile
> --- ports/multimedia/ffmpeg/Makefile 14 Aug 2008 22:08:02 -0000 1.87
> +++ ports/multimedia/ffmpeg/Makefile 15 Aug 2008 07:37:31 -0000
> @@ -140,6 +140,10 @@
> .endif
>
> ## amr
> +.if defined(WITH_AMR_NB) || defined(WITH_AMR_WB)
> +CONFIGURE_ARGS+= --enable-nonfree
> +.endif
> +
> .ifdef(WITH_AMR_NB)
> LIB_DEPENDS+= amrnb.3:${PORTSDIR}/audio/libamrnb
> CONFIGURE_ARGS+= --enable-libamr-nb
>
I did the same thing, but because a binary compiled with amr-nb/amr-wb
is no longer distributable, I decided to make it more visible to the
user and make them aware of the options they were choosing.
However, since the amr library options are non-default, having less
knobs for the user is fine. I was just being overly cautious I
suppose.
Josh
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200808151320.m7FDK3n8028638>