Date: Sat, 12 Jan 2008 16:19:19 -0500 From: David Schultz <das@FreeBSD.ORG> To: Maxim Konovalov <maxim@macomnet.ru> Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/iostat iostat.c Message-ID: <20080112211919.GA3408@VARK.MIT.EDU> In-Reply-To: <20080112235350.C10888@mp2.macomnet.net> References: <200801122037.m0CKb6CS009262@repoman.freebsd.org> <20080112205254.GB3090@VARK.MIT.EDU> <20080112235350.C10888@mp2.macomnet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jan 12, 2008, Maxim Konovalov wrote: > On Sat, 12 Jan 2008, 15:52-0500, David Schultz wrote: > > > On Sat, Jan 12, 2008, Maxim Konovalov wrote: > > > - asprintf(&devname, "%s%d", > > > + if (asprintf(&devname, "%s%d", > > > cur.dinfo->devices[di].device_name, > > > - cur.dinfo->devices[di].unit_number); > > > + cur.dinfo->devices[di].unit_number) == 1) > > > + errx(1, "asprintf() failed (out of memory?)"); > > > > err(1, "asprintf") will produce a more meaningful error message, > > by the way. Also, I think you wanted to compare the return value > > of asprintf to -1 instead of 1. > > > err(1, "asprintf") was my first version, yes. But I failed to find in > the man page it sets errno. Thanks for the review, I'll fix the typo > shortly. I don't think it always does set errno, but you can set errno to 0 before the call, and you'll get either the real error message from err() or "unknown error".
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080112211919.GA3408>