Date: Thu, 20 Dec 2001 08:32:26 +0900 From: Jun Kuriyama <kuriyama@imgsrc.co.jp> To: freebsd-stable@FreeBSD.ORG Subject: Re: if_fxp.c typo? Message-ID: <7mn10ebxbp.wl@waterblue.imgsrc.co.jp> In-Reply-To: <86y9kzqjlr.wl@keiichi01.osaka.iij.ad.jp> References: <86y9kzqjlr.wl@keiichi01.osaka.iij.ad.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
I noticed this fixes my problem, but I don't know this patch is
logically correct or not.
I think we should commit this before 4.5-RELEASE if this is correct
way. Can someone comment this?
At Thu, 22 Nov 2001 08:47:09 +0000 (UTC),
Keiichi SHIMA / 島慶一 wrote:
> fxp_stop() of the latest fxp driver do SOFTWARE_RESET when called.
> Shouldn't this be SELECTIVE_RESET?
>
> As I'm not familiar with fxp, would someone check and commit it to the
> repositry? The current code clears all the hardware mc filters
> already set, as a result, the box can't receive any multicast packets
> (this is a serious problem especially when using ipv6).
...
> --- orig/if_fxp.c Thu Nov 8 18:30:10 2001
> +++ if_fxp.c Thu Nov 22 17:22:38 2001
> @@ -1429,7 +1429,7 @@
> * Issue software reset, which also unloads the microcode.
> */
> sc->flags &= ~FXP_FLAG_UCODE;
> - CSR_WRITE_4(sc, FXP_CSR_PORT, FXP_PORT_SOFTWARE_RESET);
> + CSR_WRITE_4(sc, FXP_CSR_PORT, FXP_PORT_SELECTIVE_RESET);
> DELAY(50);
>
> /*
--
Jun Kuriyama <kuriyama@imgsrc.co.jp> // IMG SRC, Inc.
<kuriyama@FreeBSD.org> // FreeBSD Project
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7mn10ebxbp.wl>