Date: Sun, 31 Jul 2011 11:34:28 +0300 From: C++ RTMP Server Support <support@rtmpd.com> To: Doug Barton <dougb@FreeBSD.org> Cc: Jin-Sih Lin <linpct@gmail.com>, cvs-ports@FreeBSD.org, Li-Wen Hsu <lwhsu@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/crtmpserver Makefile distinfo pkg-plist ports/net/crtmpserver/files crtmpserver.in Message-ID: <7C192122-697C-49BB-AADB-446C24962000@rtmpd.com> In-Reply-To: <4E3510F7.2000405@FreeBSD.org> References: <201107301549.p6UFn7rK070976@repoman.freebsd.org> <4E3495B0.3070405@FreeBSD.org> <D2E25D19-0A8E-4081-BB71-81EE07A2BC77@rtmpd.com> <4E35108D.1040907@FreeBSD.org> <4E3510F7.2000405@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_8E6DB316-2D5A-495C-B261-DB2DC3D4441D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=iso-8859-1 Oh, I see the difference now. You basically use another construct to = gather the (default) values. IMHO, my solution is much much clear = because all variables which are read from rc.conf are in one single = place and for beginners like me the script is easier to read. Besides, you remove one variable (crtmpserver_config) and you put it's = default value inside the required_files variable, but you add another = one called pidfile. Again, IMHO, my version is easier to read. It might be an overkill as = you suggested, but I think that is a small price to pay and have the = script is clear for newbies. Seeing all the rc.conf vars in one place is = better than hunting them by eyeballing the file with care. In any case, whatever you decide is good for me and it will be the = template for the next revision. Thank you for your time On Jul 31, 2011, at 11:23 AM, Doug Barton wrote: > On 07/31/2011 01:21, Doug Barton wrote: >> +PORTVERSION=3D 1 >=20 > Should be PORTREVISION, sorry. >=20 >=20 > --=20 >=20 > Nothin' ever doesn't change, but nothin' changes much. > -- OK Go >=20 > Breadth of IT experience, and depth of knowledge in the DNS. > Yours for the right price. :) http://SupersetSolutions.com/ >=20 ------ C++ RTMP Server Support Email: support@rtmpd.com Web: http://www.rtmpd.com --Apple-Mail=_8E6DB316-2D5A-495C-B261-DB2DC3D4441D--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7C192122-697C-49BB-AADB-446C24962000>