Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 14 Jul 2003 23:46:27 +1000 (EST)
From:      Andy Farkas <andyf@speednet.com.au>
To:        Kris Kennaway <kris@freebsd.org>
Cc:        freebsd-bugs@freebsd.org
Subject:   Re: bin/47566: Suggested patch: vinum status verification
Message-ID:  <20030714233806.I37788-100000@hewey.af.speednet.com.au>
In-Reply-To: <200307141017.h6EAHIlJ094274@freefall.freebsd.org>

index | next in thread | previous in thread | raw e-mail

On Mon, 14 Jul 2003, Kris Kennaway wrote:

> Responsible-Changed-From-To: freebsd-bugs->grog
> Responsible-Changed-By: kris
> Responsible-Changed-When: Mon Jul 14 03:17:04 PDT 2003
> Responsible-Changed-Why:
> Assign to vinum author
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=47566

I like this patch and have been using it for a couple of months on a few
boxes. I have seen it report actual vinum errors which helped diagnose
problems on a box that was playing up here.

There is one error, the diff is backwards:

@@ -33,7 +33,7 @@
         then
             [ $rc -lt 1 ] && rc=1
             echo "$host vinum diffs:"
-            diff -u $bak/vinum.tmp $bak/vinum.bak
+            diff -u $bak/vinum.bak $bak/vinum.tmp
             mv $bak/vinum.bak $bak/vinum.bak2
             mv $bak/vinum.tmp $bak/vinum.bak
         fi


--

 :{ andyf@speednet.com.au

        Andy Farkas
    System Administrator
   Speednet Communications
 http://www.speednet.com.au/




help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030714233806.I37788-100000>