Date: Wed, 22 Oct 2008 18:04:52 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: "Andrey A. Chernov" <ache@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184161 - head/sys/i386/i386 Message-ID: <20081022150452.GD94031@deviant.kiev.zoral.com.ua> In-Reply-To: <200810221445.m9MEjUcq031169@svn.freebsd.org> References: <200810221445.m9MEjUcq031169@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Oct 22, 2008 at 02:45:30PM +0000, Andrey A. Chernov wrote: > Author: ache > Date: Wed Oct 22 14:45:30 2008 > New Revision: 184161 > URL: http://svn.freebsd.org/changeset/base/184161 > > Log: > Fix compiler error with missing/unneded ')' > > Modified: > head/sys/i386/i386/identcpu.c > > Modified: head/sys/i386/i386/identcpu.c > ============================================================================== > --- head/sys/i386/i386/identcpu.c Wed Oct 22 10:12:21 2008 (r184160) > +++ head/sys/i386/i386/identcpu.c Wed Oct 22 14:45:30 2008 (r184161) > @@ -842,9 +842,9 @@ printcpuinfo(void) > cpu_feature &= ~CPUID_HTT; > > if (!tsc_is_invariant && > - (strcmp(cpu_vendor, "AuthenticAMD") == 0 && > - (amd_pminfo & AMDPM_TSC_INVARIANT) != 0 || > - I386_CPU_FAMILY(cpu_id) >= 0x10))) { > + ((strcmp(cpu_vendor, "AuthenticAMD") == 0 && > + (amd_pminfo & AMDPM_TSC_INVARIANT) != 0) || > + I386_CPU_FAMILY(cpu_id) >= 0x10)) { > tsc_is_invariant = 1; > printf("\n P-state invariant TSC"); > } Taking apart commit message, I think you change is wrong semantically. Checking CPU_FAMILY without first checking vendor is meaningless. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkj/QRMACgkQC3+MBN1Mb4h/ggCg7dqXQJOZEOD/cghLxCA9pK9x 6QkAoOfopbiy1A9LwcCr+DSDHnMBfR/c =YBo5 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081022150452.GD94031>