Date: Fri, 21 Jan 2005 01:23:25 +0000 (UTC) From: Peter Wemm <peter@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/nfs nfs_vfsops.c Message-ID: <200501210123.j0L1NP1u009492@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
peter 2005-01-21 01:23:25 UTC
FreeBSD src repository
Modified files: (Branch: RELENG_4)
sys/nfs nfs_vfsops.c
Log:
Yet another pass on trying to fix the nfs statfs large-fs blocksize scaler.
Casting the result of the 64 bit division to 32 bits (thus discarding the
upper 32 bits) and then looking at the truncated result to try and figure
out if the untruncated result would fit in 32 bits was utterly useless.
I am still not sure that it is right, but it has a chance of working now.
I'm not at all sure about the sign handling. NFSv3 only reports positive
values here, but correctness of handling the 63/64 bit signs on nfs
volumes is not a problem we'll likely have to deal with for some time. I
think the "most correct" test is for an unsigned division testing for
exceeding LONG_MAX, since we should never end up with a negative number to
compare against LONG_MIN.
Revision Changes Path
1.91.2.9 +6 -6 src/sys/nfs/nfs_vfsops.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200501210123.j0L1NP1u009492>