Date: Fri, 15 Apr 2005 08:30:32 GMT From: Julian Elischer <julian@elischer.org> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/79884: [PATCH] ng_echo(4) should use "error" from NG_FWD_ITEM_HOOK Message-ID: <200504150830.j3F8UWwJ050412@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/79884; it has been noted by GNATS. From: Julian Elischer <julian@elischer.org> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl>, Julian Elischer <julian@FreeBSD.org>, bug-followup@FreeBSD.org Subject: Re: kern/79884: [PATCH] ng_echo(4) should use "error" from NG_FWD_ITEM_HOOK Date: Fri, 15 Apr 2005 01:27:07 -0700 Ruslan Ermilov wrote: > On Wed, Apr 13, 2005 at 10:12:29PM +0000, Wojciech A. Koszek wrote: > [...] > >>NG_FWD_ITEM_HOOK prepends to "error" appropriate value if needed. Currently, >>"error" is not used after NG_FWD_ITEM_HOOK. ng_echo(4) should make use of >>it. >> > > Julian changed the semantics in rev. 1.9 of ng_echo.c, without an obvious > reason. Let's hear what was the reason, if there were any. Julian? probably just a "braino" during editing, though I think there is a large possibility that it is not possible to get an error. certainly it should be ok to use the error value, > > > Cheers,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200504150830.j3F8UWwJ050412>