Date: Mon, 7 Aug 2006 15:45:56 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Prafulla Deuskar <pdeuskar@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h Message-ID: <20060807114556.GC96644@FreeBSD.org> In-Reply-To: <20060804162149.GB22299@hub.freebsd.org> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <20060804095414.GU96644@FreeBSD.org> <20060804143825.GA8797@hub.freebsd.org> <20060804151422.GE96644@FreeBSD.org> <20060804162149.GB22299@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Prafulla, On Fri, Aug 04, 2006 at 04:21:49PM +0000, Prafulla Deuskar wrote: P> > Thanks. Any objections about merging the HEAD to RELENG_6 soon? P> P> Jack Vogel is doing the merge - I will send it out to you for review. P> So let us plan on committing early next week? The merge is very simple: 1) take the driver from HEAD 2) rename VLAN_INPUT_TAG() macro to VLAN_INPUT_TAG_NEW() 3) revert revision 1.105, since this functionality isn't yet in RELENG_6 I have prepared the patch last week and posted it on STABLE, and several people have already reported that they successfully run it. So, we can commit to RELENG_6, I think. P> Is there a report on what coverty found with if_em_hw.c? Coverity complains that the return value of em_read_phy_reg() is somtimes checked and sometimes is not. Can you please tell, whether this is important report or can it be ignored? -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060807114556.GC96644>