Date: Fri, 30 Sep 2016 09:56:59 -0000 From: "Ganael LAPLANCHE" <martymac@FreeBSD.org> To: Ultima <ultima1252@gmail.com> Cc: freebsd-current@freebsd.org,freebsd-fs@freebsd.org Subject: Re: [patch] Improving the 'zpool labelclear' command Message-ID: <20160930095205.M29574@martymac.org> In-Reply-To: <CANJ8om4A6f20F5Z9W-m0hCCQ5A207ftQOzdzXWF%2Buw9SJ%2B-3Dg@mail.gmail.com> References: <CANJ8om4xX2pAkCxPTc8MarQo08cZ7R8j_M7aEKKV=2rtmm71yQ@mail.gmail.com> <op.yohxcavskndu52@d93fd8ae.cm-21.dynamic.ziggo.nl> <CANJ8om7aoG_Dy%2B7vCsBhuk9dcSsr60tfzrjhaspzPh9nj8vw-w@mail.gmail.com> <20160929121325.M80322@martymac.org> <CANJ8om4A6f20F5Z9W-m0hCCQ5A207ftQOzdzXWF%2Buw9SJ%2B-3Dg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 29 Sep 2016 14:13:52 -0400, Ultima wrote > > In case you are interested, I have posted a patch to improve the 'zpool > > labelclear' command here : > > > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204622 > > > > - force ('-f') will now allow to erase labels, even if they are broken > > (restoring the behaviour of our previous -FreeBSD- version of labelclear) > > - You can select which label you want to erase (beginning, end or > > specific index) > > - You can use a 'minimal' mode which will invalidate a label by changing > > only a single byte. This is useful to minimize the chances to > > overwrite/destroy a FS that would have been created over the label, but > > still leaving the label visible. > > This patch looks good its too bad the core hasn't looked at it > yet. Ill do some testing and report any issues found. Some > points you bring up in the bug are quite valid. Thanks for > working on this! =] Thanks. Yes, it would be nice if a src committer could take a look at it. Any feedback welcome :) -- Ganael LAPLANCHE <ganael.laplanche@martymac.org> http://www.martymac.org | http://contribs.martymac.org FreeBSD: martymac <martymac@FreeBSD.org>, http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160930095205.M29574>