Date: Wed, 13 Apr 2005 20:00:49 +0200 From: Arjan Van Leeuwen <avleeuwen@gmail.com> To: Warner Losh <imp@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/pci pcib_if.m Message-ID: <d86b4873050413110054f18beb@mail.gmail.com> In-Reply-To: <200504131630.j3DGUUDu060801@repoman.freebsd.org> References: <200504131630.j3DGUUDu060801@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/13/05, Warner Losh <imp@freebsd.org> wrote: > imp 2005-04-13 16:30:30 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/dev/pci pcib_if.m > Log: > Default to a interrupt router that returns an invalid interrupt. > Otherwise, busses that implement the pcib interface that forget to > implement pcib_route_interrupt would return EIO, which the caller > interprets as 'use interrupt 6'. This is likely the cause of much of > the grief that we had when I enabled power modes for the cardbus > bridge, since the card needed to reroute the interrupt to it and it > was getting 6 which was d by the pccbb sanity checks. >=20 > Revision Changes Path > 1.6 +9 -1 src/sys/dev/pci/pcib_if.m This seems to break my kernel build: awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/dev/sound/pcm/ac97_if.m -c ; cc -c -O2 -pipe -fno-strict-aliasing -march=3Dpentium3 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -std=3Dc99 -g -nostdinc -I- -I. -I/usr/src/sys -I/usr/src/sys/contrib/dev/acpica -I/usr/src/sys/contrib/altq -I/usr/src/sys/contrib/ipfilter -I/usr/src/sys/contrib/pf -I/usr/src/sys/contrib/dev/ath -I/usr/src/sys/contrib/dev/ath/freebsd -I/usr/src/sys/contrib/ngatm -I/usr/src/sys/dev/twa -D_KERNEL -include opt_global.h -fno-common -finline-limit=3D8000 --param inline-unit-growth=3D100 --param large-function-growth=3D1000 -mno-align-long-strings -mpreferred-stack-boundary=3D2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -ffreestanding -Werror ac97_if.c pcib_if.c: In function `null_route_interrupt': pcib_if.c:24: error: `PCI_INVALID_IRQ' undeclared (first use in this functi= on) pcib_if.c:24: error: (Each undeclared identifier is reported only once pcib_if.c:24: error: for each function it appears in.) pcib_if.c: At top level: pcib_if.c:23: warning: 'null_route_interrupt' defined but not used *** Error code 1 1 error *** Error code 2 1 error *** Error code 2 1 error Arjan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d86b4873050413110054f18beb>