Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 12 Jul 1996 17:57:55 -0700 (PDT)
From:      "JULIAN Elischer" <julian@ref.tfs.com>
To:        bde@freefall.freebsd.org (Bruce Evans)
Cc:        CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org
Subject:   Re: cvs commit:  src/sys/i386/boot/biosboot asm.h start.S
Message-ID:  <199607130057.RAA02771@ref.tfs.com>
In-Reply-To: <199607120542.WAA02603@freefall.freebsd.org> from "Bruce Evans" at Jul 11, 96 10:42:04 pm

next in thread | previous in thread | raw e-mail | index | archive | help
> 
> 
> bde         96/07/11 22:42:03
> 
>   Modified:    sys/i386/boot/biosboot  asm.h start.S
>   Log:
>   Moved the definition of DEBUGMSG() from asm.h to start.S.  This macro
>   is only appropriate to use in the special environment of start.S (real
>   mode plus some conventions about not saving registers), and asm.h is
>   supposed to be for generic macros.
 This is a bad move..
 DEBUGMSG is useful right up through quite a bit of boot2.S
 I used it ito find how far I was getting into boot2.S
 which is the reason that it was moved to asm.h
 can you please put it back there!?



>   
>   Removed some unnecessary parentheses.
>   
>   Revision  Changes    Path
>   1.6       +1 -8      src/sys/i386/boot/biosboot/asm.h
>   1.8       +12 -5     src/sys/i386/boot/biosboot/start.S
> 




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199607130057.RAA02771>