Date: Fri, 27 Dec 2024 14:24:46 +0000 From: Nuno Teixeira <eduardo@freebsd.org> To: Baptiste Daroussin <bapt@freebsd.org> Cc: FreeBSD CURRENT <freebsd-current@freebsd.org> Subject: Re: base64.h problems with rtorent port Message-ID: <CAFDf7U%2ByL8uBKQKW83WDwQVo=HGUWrAg_6h7KD21E18R58gxWg@mail.gmail.com> In-Reply-To: <boltawtg355cfkad4ko6wl6gli7a3ijqtlzpxqmtov2qgbi6if@pqdpvbb7emd5> References: <CAFDf7UJ3uc0jUasWwOUK1cQkWV65Za9uR=z6kcPCaD36QwcX1A@mail.gmail.com> <e794b549374b282f1b5211f703a86a8682215fde@freebsd.org> <CAFDf7U%2BLkfSXDCP0kw8jvd-6Xue0ge1mubrDBOotCq9cuMP3aA@mail.gmail.com> <boltawtg355cfkad4ko6wl6gli7a3ijqtlzpxqmtov2qgbi6if@pqdpvbb7emd5>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Perfect! I'm thinking using a radio option where we can select one of xml parsers or none as supported upstream, defaulting to TINYXML. A quick look in repology shows that at least 3 linux distros use directly `--with-xmlrpc-tinyxml2` with 0.15.0 pkgs. I'm ok with simplifying port or keep radio option. Cheers! ``` OPTIONS_DEFINE= DOCS EXAMPLES IPV6 OPTIONS_DEFAULT= TINYXML OPTIONS_RADIO= XML OPTIONS_RADIO_XML= TINYXML XMLRPC XMLRPC_DESC= Compile with xmlrpc-c support IPV6_CONFIGURE_ENABLE= ipv6 TINYXML_CONFIGURE_ON= --with-xmlrpc-tinyxml2 XMLRPC_LIB_DEPENDS= libxmlrpc.so:net/xmlrpc-c XMLRPC_CONFIGURE_ON= --with-xmlrpc-c ``` Baptiste Daroussin <bapt@freebsd.org> escreveu (sexta, 27/12/2024 à(s) 13:17): > On Fri 27 Dec 12:48, Nuno Teixeira wrote: > > Hello Baptiste, > > > > Yes, this proves that my C skills are awesome :) > > > > Upstream spotted it too, and in fact, base64.h is missing from tarball. > > Now I'm waiting on upstream to find the best and fast way to include > > missing file so I can test build. > > > > Thanks very much, > > I have sent a PR which should fix the issue they need to reroll their > distfiles. > -- Nuno Teixeira FreeBSD UNIX: <eduardo@FreeBSD.org> Web: https://FreeBSD.org [-- Attachment #2 --] <div dir="ltr"><div>Perfect!<br><br></div><div>I'm thinking using a radio option where we can select one of xml parsers or none as supported upstream, defaulting to TINYXML.</div><div><br></div><div>A quick look in repology shows that at least 3 linux distros use directly `--with-xmlrpc-tinyxml2` with 0.15.0 pkgs. I'm ok with simplifying port or keep radio option.<br><br></div><div>Cheers!<br></div><div><br></div><div>```<br></div><div>OPTIONS_DEFINE= DOCS EXAMPLES IPV6<br>OPTIONS_DEFAULT= TINYXML<br>OPTIONS_RADIO= XML<br>OPTIONS_RADIO_XML= TINYXML XMLRPC<br>XMLRPC_DESC= Compile with xmlrpc-c support<br><br>IPV6_CONFIGURE_ENABLE= ipv6<br>TINYXML_CONFIGURE_ON= --with-xmlrpc-tinyxml2<br>XMLRPC_LIB_DEPENDS= libxmlrpc.so:net/xmlrpc-c<br>XMLRPC_CONFIGURE_ON= --with-xmlrpc-c<br>```<br></div></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">Baptiste Daroussin <<a href="mailto:bapt@freebsd.org">bapt@freebsd.org</a>> escreveu (sexta, 27/12/2024 à(s) 13:17):<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri 27 Dec 12:48, Nuno Teixeira wrote:<br> > Hello Baptiste,<br> > <br> > Yes, this proves that my C skills are awesome :)<br> > <br> > Upstream spotted it too, and in fact, base64.h is missing from tarball.<br> > Now I'm waiting on upstream to find the best and fast way to include<br> > missing file so I can test build.<br> > <br> > Thanks very much,<br> <br> I have sent a PR which should fix the issue they need to reroll their distfiles.<br> </blockquote></div><div><br clear="all"></div><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><font color="#888888">Nuno Teixeira</font></div><div><div><font color="#888888"> FreeBSD UNIX: <eduardo@FreeBSD.org> Web: <a href="https://FreeBSD.org" rel="noreferrer" target="_blank">https://FreeBSD.org</a><br></font></div></div></div></div>;home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7U%2ByL8uBKQKW83WDwQVo=HGUWrAg_6h7KD21E18R58gxWg>