Date: Mon, 2 Jun 2008 14:45:15 -0400 From: John Baldwin <jhb@freebsd.org> To: Stefan Farfeleder <stefanf@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/bin/sh expand.c parser.c parser.h Message-ID: <200806021445.15974.jhb@freebsd.org> In-Reply-To: <200805151955.m4FJtRMb099378@repoman.freebsd.org> References: <200805151955.m4FJtRMb099378@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 15 May 2008 03:55:27 pm Stefan Farfeleder wrote:
> stefanf 2008-05-15 19:55:27 UTC
>
> FreeBSD src repository
>
> Modified files:
> bin/sh expand.c parser.c parser.h
> Log:
> Expand $LINENO to the current line number. This is required by
SUSv3's "User
> Portability Utilities" option.
>
> Often configure scripts generated by the autotools test if $LINENO works
and
> refuse to use /bin/sh if not.
>
> Package test run by: pav
This breaks the build of editors/openoffice-2
Specifically, the libxslt configure script has two statements like this:
if test "1" == "1"
then
blah blah
endif
Specifically note the "==" passed to test(1). POSIX says this should be "=",
and that's all our test(1) implements. The bash manpage for the builtin-test
command says:
string1 == string2
True if the strings are equal. = may be used in place of == for
strict POSIX compliance.
IOW, it encourages "==". I'm not sure if we want to force the use of bash for
certain ports or if we want to just implement bash'isms in our tools as we
encounter them (or patch the port?). In this case the patch is not
complicated (just replace the two '==' with '=' in libxslt's configure
script).
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200806021445.15974.jhb>