Date: Wed, 23 Jan 2019 15:51:56 -0800 From: Enji Cooper <yaneurabeya@gmail.com> To: Enji Cooper <ngie@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343368 - head/lib/libc/tests/sys Message-ID: <E8A5FF4A-20E0-44C8-A01D-5FBBD8E70E30@gmail.com> In-Reply-To: <201901232348.x0NNmvO5098255@repo.freebsd.org> References: <201901232348.x0NNmvO5098255@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jan 23, 2019, at 3:48 PM, Enji Cooper <ngie@FreeBSD.org> wrote: >=20 > Author: ngie > Date: Wed Jan 23 23:48:57 2019 > New Revision: 343368 > URL: https://svnweb.freebsd.org/changeset/base/343368 >=20 > Log: > Fix up r343367 >=20 > I should have only changed the format qualifier with the `size_t` = value, > `length`, not the other [`off_t`] value, `dest_file_size`. >=20 > MFC after: 1 month > MFC with: r343362, r343365, r343367 > Approved by: emaste (mentor; implicit) > Reported by: gcc 8.x Lessons to learn from this: is, again, always run =E2=80=9Cmake = universe=E2=80=9D beforehand on the releng machines. I swore I did this = before, but I can=E2=80=99t remember (and I didn=E2=80=99t run it before = committing the code). Trying to figure out a reasonable way to use my GitHub fork and = do work with svn =E2=80=94 the workflow is extremely error prone right = now (this is just one symptom of that issue). Thank you for your patience, everyone. It=E2=80=99s been far too = long since I=E2=80=99ve earned pointyhats :/. Cheers, -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E8A5FF4A-20E0-44C8-A01D-5FBBD8E70E30>