Date: Mon, 29 Apr 2024 14:37:37 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 86fbb05da1ae - main - ctl: Fix CTL GET EVENT STATUS NOTIFICATION valid bits Message-ID: <202404291437.43TEbbJS080922@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=86fbb05da1aed64eb9b09d7f3b2cd72048c959c1 commit 86fbb05da1aed64eb9b09d7f3b2cd72048c959c1 Author: HP van Braam <hp@tmm.cx> AuthorDate: 2024-04-29 14:34:46 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2024-04-29 14:37:30 +0000 ctl: Fix CTL GET EVENT STATUS NOTIFICATION valid bits Linux as an initiator periodically sends the following to SCSI cdrom devices: 4a 01 00 00 10 00 00 00 08 00 According to the ctl_cmd_entry for this command this is invalid which leads to a lot of failed SCSI commands. The mask in this commit is based off of an early draft of the mmc standard, https://www.t10.org/ftp/t10/document.97/97-108r0.pdf, as well as subsequent standards (mmc2 through mmc6). This solves the issue with Linux initiators. Signed-off-by: HP van Braam <hp@tmm.cx> Reviewed by: imp, mav Pull Request: https://github.com/freebsd/freebsd-src/pull/1201 --- sys/cam/ctl/ctl_cmd_table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/cam/ctl/ctl_cmd_table.c b/sys/cam/ctl/ctl_cmd_table.c index a62c5e8c1e81..28d937edd7dc 100644 --- a/sys/cam/ctl/ctl_cmd_table.c +++ b/sys/cam/ctl/ctl_cmd_table.c @@ -1228,7 +1228,7 @@ const struct ctl_cmd_entry ctl_cmd_table[256] = CTL_CMD_FLAG_ALLOW_ON_PR_RESV | CTL_FLAG_DATA_IN, CTL_LUN_PAT_NONE, - 10, {0x02, 0x01, 0, 0, 0, 0xff, 0xff, 0xff, 0x07}}, + 10, {0xe1, 0, 0, 0x7e, 0, 0, 0xff, 0xff, 0x07}}, /* 4B PAUSE/RESUME */ {NULL, CTL_SERIDX_INVLD, CTL_CMD_FLAG_NONE, CTL_LUN_PAT_NONE},
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202404291437.43TEbbJS080922>