Date: Fri, 24 Feb 2012 12:38:44 +1300 From: Andrew Thompson <thompsa@FreeBSD.org> To: Doug Barton <dougb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r232080 - in head: share/man/man4 sys/net Message-ID: <CAFAOGNQmy2pJN5L=apqGH1_d7CTuZ2Qt_n05xV0FKX8=Kb-GYQ@mail.gmail.com> In-Reply-To: <4F46CA60.6030409@FreeBSD.org> References: <201202232156.q1NLurPU025054@svn.freebsd.org> <4F46CA60.6030409@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 24 February 2012 12:23, Doug Barton <dougb@freebsd.org> wrote: > First, I'm always glad to see devs updating the documentation, so please > don't take this as in any way being critical, just trying to help. :) n/p, I like feedback. > On 02/23/2012 13:56, Andrew Thompson wrote: >> Modified: head/share/man/man4/lagg.4 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/share/man/man4/lagg.4 =A0 =A0 =A0 =A0Thu Feb 23 21:54:04 2012 = =A0 =A0 =A0 =A0(r232079) >> +++ head/share/man/man4/lagg.4 =A0 =A0 =A0 =A0Thu Feb 23 21:56:53 2012 = =A0 =A0 =A0 =A0(r232080) >> @@ -142,10 +142,12 @@ and >> =A0modes will use the RSS hash from the network card if available to avo= id >> =A0computing one, this may give poor traffic distribution if the hash is= invalid >> =A0or uses less of the protocol header information. >> -Local hash computation can be forced by setting the >> +Local hash computation can be forced per interface by setting the > > This is a great example of why we use short lines in the man page > sources. It allows people to come along later and add text without > having to make changes to multiple lines. I can see your point here. >> =A0.Va net.link.lagg.X.use_flowid >> =A0.Xr sysctl 8 >> -variable to zero where X is the interface number. >> +variable to zero where X is the interface number, the default for >> +new interfaces is set via >> +.Va net.link.lagg.default_use_flowid . > > If adding a comma there was the right change the new clause should still > have started on the next line, for the reason described above. However, > what you added is actually a sentence that can/should stand on its own. Fixed. Andrew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFAOGNQmy2pJN5L=apqGH1_d7CTuZ2Qt_n05xV0FKX8=Kb-GYQ>