Date: Tue, 22 Dec 2009 11:26:51 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: "M. Warner Losh" <imp@bsdimp.com> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, dougb@FreeBSD.org, jhb@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r200606 - in head/sys: compat/freebsd32 sys Message-ID: <864onj8ftg.fsf@ds4.des.no> In-Reply-To: <20091221.204959.104237699577179806.imp@bsdimp.com> (M. Warner Losh's message of "Mon, 21 Dec 2009 20:49:59 -0700 (MST)") References: <200912161541.53834.jhb@freebsd.org> <868wd0cyjd.fsf@ds4.des.no> <4B2C127A.8060509@FreeBSD.org> <20091221.204959.104237699577179806.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
"M. Warner Losh" <imp@bsdimp.com> writes: > The trouble is that we need to do this globally, or certain > definitions don't get defined. It is easier to just #error out than > hack config to do the right thing I think... Suggestion: Introduce <sys/_compat.h> which includes "opt_compat.h" and contains the appropriate logic, then s@"opt_compat.h"@<sys/_compat.h>@ throughout the kernel. While you're there, add #include <sys/_compat.h> inside #ifdef _KERNEL in headers that use the COMPAT_FREEBSDn macros (e.g. fcntl.h) and see what breaks... DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?864onj8ftg.fsf>