Date: Wed, 8 Oct 2008 14:09:31 -0400 From: John Baldwin <jhb@freebsd.org> To: freebsd-threads@freebsd.org Cc: John Hein <jhein@timing.com> Subject: Re: pthread_cleanup_push & pthread_cleanup_pop usage Message-ID: <200810081409.31822.jhb@freebsd.org> In-Reply-To: <18668.10465.699531.162573@gromit.timing.com> References: <18668.10465.699531.162573@gromit.timing.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 07 October 2008 11:28:33 pm John Hein wrote:
> In June pthread_cleanup_push & pthread_cleanup_pop were changed to macros
> that look like so...
>
> +#define pthread_cleanup_push(cleanup_routine, cleanup_arg)
\
> + {
\
> + struct _pthread_cleanup_info __cleanup_info__;
\
> + __pthread_cleanup_push_imp(cleanup_routine,
cleanup_arg,\
> + &__cleanup_info__);
\
> + {
> +
> +#define pthread_cleanup_pop(execute)
\
> + }
\
> + __pthread_cleanup_pop_imp(execute);
\
> + }
> +
>
>
> This breaks code where the pop is done in an inner block level.
>
> simplified example:
>
> pthread_cleanup_push(docleanup, &foo);
> try
> {
> dostuff();
> }
> catch (...)
> {
> pthread_cleanup_pop(1);
> throw;
> }
> pthread_cleanup_pop(1);
>
> Does anyone have a recommended fix?
Don't Do That (tm). The spec explicitly states that they can be defined as
macros and that code using it needs to put them in the same block.
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200810081409.31822.jhb>