Date: Thu, 9 Mar 2006 11:03:07 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Warner Losh <imp@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.README Message-ID: <20060309090307.GK54826@ip.net.ua> In-Reply-To: <200603090133.k291XcfB005631@repoman.freebsd.org> References: <200603090133.k291XcfB005631@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--hl1kWnBARzJiTscN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 09, 2006 at 01:33:38AM +0000, Warner Losh wrote: > imp 2006-03-09 01:33:38 UTC >=20 > FreeBSD src repository >=20 > Modified files: > share/mk bsd.README=20 > Log: > Now that we now spell NO_MAN=3Dxxx MAN=3D, update the docs. > =20 > Submitted by: John Hein > =20 > Revision Changes Path > 1.30 +1 -1 src/share/mk/bsd.README >=20 I object. 1) This is not common: grep '^NO_MAN=3D' {bin,usr.bin,sbin,usr.sbin}/*/Makefile |wc -l 10 grep '^MAN=3D[[:space:]]*(#.*)?$' {bin,usr.bin,sbin,usr.sbin}/*/Makefile |w= c -l 0 2) MAN=3D is worse for performance (with NO_MAN, bsd.man.mk is not processes at all which is faster). 3) This is in contrast with NO_OBJ and similar knobs. I can only suggest to make it spell "NO_MAN=3D", i.e., without any value. Was there some discussion that I've missed? Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --hl1kWnBARzJiTscN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFED+9KqRfpzJluFF4RAgnBAJoD2V9l+X5tjwOocTLPPn0ScJV3/QCfSSGJ UqQ6RPhHjNOyfcss59hTiLw= =Gm6V -----END PGP SIGNATURE----- --hl1kWnBARzJiTscN--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060309090307.GK54826>