Date: Mon, 6 Jan 2014 19:37:38 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Adrian Chadd <adrian@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r260363 - head/sys/dev/ath Message-ID: <20140106173738.GG59496@kib.kiev.ua> In-Reply-To: <CAJ-VmomRefeAdd_VdRO8Q8jTpC2hbC7Q22vy_uJB7FX=OUUFLQ@mail.gmail.com> References: <201401060348.s063mW8C031852@svn.freebsd.org> <20140106035139.GC59496@kib.kiev.ua> <CAJ-VmomRefeAdd_VdRO8Q8jTpC2hbC7Q22vy_uJB7FX=OUUFLQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--rH0ZJBuyEosIc0Vp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 05, 2014 at 09:37:21PM -0800, Adrian Chadd wrote: > On 5 January 2014 19:51, Konstantin Belousov <kostikbel@gmail.com> wrote: > > On Mon, Jan 06, 2014 at 03:48:32AM +0000, Adrian Chadd wrote: > >> Author: adrian > >> Date: Mon Jan 6 03:48:32 2014 > >> New Revision: 260363 > >> URL: http://svnweb.freebsd.org/changeset/base/260363 > >> > >> Log: > >> Correctly remove entries from the relevant receive ath_buf list befo= re > >> freeing them. > >> > >> The current code would walk the list and call the buffer free, which > >> didn't remove it from any lists before pushing it back on the free l= ist. > >> > >> Tested: AR9485, STA mode > >> > >> Noticed by: dillon@apollo.dragonflybsd.org > > This is a NOP, right ? >=20 > Nope. the previous version didn't remove the entries from the list. > that's the bug. Hm, you mean that the previous version did not TAILQ_INIT() after the loop ? Then I agree. --rH0ZJBuyEosIc0Vp Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJSyunhAAoJEJDCuSvBvK1BAc4P/A+wbYIbG11/iJf6045gbnLc ZRyLfcnNW7rMUC7NN5mKa6V3bIbG/R3XE0g+VHWSP/YDF1o67pU7+kMzlI4/JTzZ X1nRwgKm8gI4iGq/OfAgHeuQdXGosjT031iDMD+9bsNPjllQOZNFG5y6mEl0nS/9 42nhaYKwjg0n0bZs2seidnUbujkZTHtrWPeB81D9mhcz3xCU0l8XUxTC6pZFWt5d BkDhugI+DfqB8qU4TzBKt1LIsoQLUuxhPNimoX+5pJwTHF5N6Gu2BRtyK6i12Fnx rjZufZHTLokBysGnoLpfZxBpdFIq5egYrqoe9+Oinda7I6XoAwsQva+qftLs28ec j3385PevNI1+YkaUGXKdwyM3gxsyRvIJmZR3IYf7wQoywh7cv3CaewpXgoBhxP4G ZiH4zFDxcdP0GxR2L68QW6m/RAZKQkXetwdke709uOAFHtImYt2f7I8ffTZEOfCB IJOKhSgqL3sKm+5vCMQGzfVEzUkOR0N+7zCF11aXQZYmKp6Or31rovXdf2nIPTA9 F45dhXa/ZYGA0cj2RHWDbWTAoJgSibwH5j//SUKD/S8dCXyPFgF8NH02/qI5rQja R6q49giV+2ojWtohJX7AwTHpL2+v6ktMJixdYYNmtkfRHTeIv1BD5tvbajS8KJh9 UPdVP5IMXjA3CNFC7foX =6tUW -----END PGP SIGNATURE----- --rH0ZJBuyEosIc0Vp--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140106173738.GG59496>