Date: Tue, 21 Aug 2001 16:46:40 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: Mark Murray <markm@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/usr.bin/su su.c Message-ID: <20010821164246.J1960-100000@besplex.bde.org> In-Reply-To: <20010820192334.B83948@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 20 Aug 2001, Ruslan Ermilov wrote: > On Mon, Aug 20, 2001 at 05:46:11AM -0700, Mark Murray wrote: > > markm 2001/08/20 05:46:11 PDT > > > > Modified files: > > usr.bin/su su.c > > Log: > > Very minor stylistic nit. > > > > Discussed with: ru > > > > Revision Changes Path > > 1.44 +2 -3 src/usr.bin/su/su.c This seems to just add a style bug. It removes a cast to void. If casting function return values to void is correct anywhere, then it is correct for fprintf() to stderr. > Yes, but please fix style(9) example then as well, so > people don't do it wrong further. The example in style(9) seems to be correct here. (It is wrong later. Using sysexits(3) is not normal style.) Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010821164246.J1960-100000>