Date: Mon, 16 Oct 2000 00:39:23 -0700 From: Brian Somers <brian@Awfulhak.org> To: Bruce Evans <bde@zeta.org.au> Cc: kargl@apl.washington.edu, freebsd-current@FreeBSD.ORG, brian@Awfulhak.org Subject: Re: more endian.h breakage; patch included. Message-ID: <200010160739.e9G7dNY21088@hak.lan.Awfulhak.org> In-Reply-To: Message from Bruce Evans <bde@zeta.org.au> of "Mon, 16 Oct 2000 11:44:20 %2B1100." <Pine.BSF.4.21.0010161137470.2121-100000@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Sun, 15 Oct 2000, Steven G. Kargl wrote:
>
> > There is another patch needed in libdialog.
>
> No patches are needed in applications; endian.h should be unbroken.
In what way ?
ntohl() & ntonl() were previously wrong to return u_long.
They now return uint32_t (which requires sys/types.h).
They *could* be changed to return u_int32_t, but this doesn't seem to
be the best way forward.
They *could* be changed to return unsigned, but I think this is worse
than u_int32_t.
I guess another alternative is to move the BYTE_ORDER into a
different file and stop including endian.h from wait.h, but this
seems wrong too.
> Bruce
--
Brian <brian@Awfulhak.org> <brian@[uk.]FreeBSD.org>
<http://www.Awfulhak.org>; <brian@[uk.]OpenBSD.org>
Don't _EVER_ lose your sense of humour !
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200010160739.e9G7dNY21088>