Date: Mon, 9 Jan 2012 09:52:30 +0100 From: Stefan Bethke <stb@lassitu.de> To: Adrian Chadd <adrian@freebsd.org> Cc: freebsd-arch@freebsd.org Subject: Re: Where should I put ar71xx_* modules? Message-ID: <DFFFE611-01A1-4B3F-8DFF-72E410483D5D@lassitu.de> In-Reply-To: <CAJ-VmomWF6g1kgrzKxvsveeOjc-sNoKNoL090331%2BwV4OPSAfw@mail.gmail.com> References: <CAJ-Vmom08uFV%2BNMryjZon_xnqo95MAK8r2=0s_JqRet7EMdn4g@mail.gmail.com> <09C21BD6-46E1-4593-9E3C-183CF229A613@lassitu.de> <CAJ-VmomWF6g1kgrzKxvsveeOjc-sNoKNoL090331%2BwV4OPSAfw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 09.01.2012 um 09:39 schrieb Adrian Chadd:
> On 8 January 2012 23:59, Stefan Bethke <stb@lassitu.de> wrote:
>> Am 09.01.2012 um 00:42 schrieb Adrian Chadd:
>>=20
>>> Hi,
>>>=20
>>> In order to fit an lzma'd kernel in 892 kilobytes of flash (that's =
892
>>> * 1024 bytes), I've needed to break out a few things into modules.
>>>=20
>>> I'd like to commit a couple of modules - for example,
>>> ar71xx_ehci/ar71xx_ohci for USB stuff - but I don't want them built
>>> for anything other than ar71xx builds. Thus I don't see the reason =
for
>>> putting them in sys/modules/Makefile.
>>>=20
>>> They build fine if they're included in MODULES_OVERRIDE in the
>>> relevant kernel config file.
>>>=20
>>> So is it ok to just commit some modules in sys/modules/ which aren't
>>> in the Makefile, and instead include them in the relevant SoC kernel
>>> configs so they're built? Or is there some other tradition for doing
>>> this?
>>=20
>> Why would it hurt to have them connected to the standard build? Doe =
the tinderboxes build modules?
>=20
> Because they have to compile only for MIPS? And they'd only work for =
ar71xx?
We have lots of modules that have specific requirements; they're still =
connected to the build. What warrants different handling here? You =
could put them under .if ${MACHINE_CPUARCH} !=3D "mips" like a number of =
them are already.
Stefan
--=20
Stefan Bethke <stb@lassitu.de> Fon +49 151 14070811
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DFFFE611-01A1-4B3F-8DFF-72E410483D5D>