Date: Thu, 15 Dec 2011 15:56:51 +0700 From: Max Khon <fjoe@samodelkin.net> To: Garrett Cooper <yanegomi@gmail.com> Cc: Alexander Best <arundel@freebsd.org>, Doug Barton <dougb@freebsd.org>, current@freebsd.org, Warner Losh <imp@bsdimp.com> Subject: Re: Remove debug echo Message-ID: <CADe0-4n_LzKy%2BGr=1ZtxBuqwAditkeQEsNzVgVdhz526MCxc_w@mail.gmail.com> In-Reply-To: <CAGH67wSYSTkxZp-Cf6NiPJESF0ry_ddhfPs3rPMo27J9dzRVuw@mail.gmail.com> References: <201111291607.26546.jhb@freebsd.org> <A6C0CFB3-A657-41AA-8A2E-172D95BD0F98@bsdimp.com> <20111201002515.GA50028@freebsd.org> <CAGH67wQFecLHFsANmWFSr6e%2B99P1QY9erNzoXFmJG40RntFazQ@mail.gmail.com> <20111201014349.GA61475@freebsd.org> <CAGH67wT18DLu%2BOhOOw-Pjyq9az0pWD39y4nuDY-nDyPOKbmd8Q@mail.gmail.com> <CAGH67wQGnSfnO0H4ok2=czm7uxdwY%2BBuDmtQdwuswjSBGt8szw@mail.gmail.com> <CADe0-4niyiLyTSofbnpovb4B-WpjnC9VEEM3_GeZFi-xVws=LQ@mail.gmail.com> <CAGH67wSYSTkxZp-Cf6NiPJESF0ry_ddhfPs3rPMo27J9dzRVuw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Garrett, On Thu, Dec 15, 2011 at 10:39 AM, Garrett Cooper <yanegomi@gmail.com> wrote: >> If someone would please, PLEASE commit this.. I will give you beer, or > >> wine, or a copy of Skyrim, or a few months subscription to WoW, or > >> something else of value to you that we could negotiate :)... I'm quite > >> frankly tired of having to playing guessing games fishing through logs > >> trying to determine build errors on FreeBSD if and when they do occur > >> with pmake, and I'm sure that a number of developers and build/release > >> engineers out there are in the same boat as I am. > > > > > > Can you explain why did you remove MESSAGE() invocations in your patch? > > Other than that the patch looks good to me. > > I thought that printing out MESSAGE and the more informative > *printf was kind of redundant. > Thanks! > -Garrett > > PS A sidenote why I bypassed MESSAGE(..): if I used the macro, make > would segfault as MESSAGE depends on targFmt and targPrefix being set > to something sane (they both default to NULL -- one explicitly, the > other implicitly because it's in the .BSS). These vars are only set in > one section of code, but I took the easy route out to avoid > accidentally breaking other code paths and because what I did in the > previously attached patch was simple to implement and test. > I did not mean that you should use MESSAGE() for your purposes, but removing existing "invocations" seems to be unnecessary. Max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADe0-4n_LzKy%2BGr=1ZtxBuqwAditkeQEsNzVgVdhz526MCxc_w>