Date: Mon, 20 Nov 2017 21:30:11 -0800 From: Mark Millard <markmi@dsl-only.net> To: Warner Losh <imp@FreeBSD.org>, svn-src-head@freebsd.org Subject: Re: svn commit: r326038 - in head/stand: . arm/uboot efi efi/fdt fdt i386 mips/beri mips/beri/boot2 mips/beri/loader mips/uboot ofw/libofw powerpc/boot1.chrp powerpc/kboot powerpc/ofw powerpc/ps3 power... Message-ID: <2434FC04-1FF3-48B0-8743-78412673616F@dsl-only.net>
next in thread | raw e-mail | index | archive | help
It looks to me like head/stand/powerpc/boot1.chrp/Makefile might
have +=3D vs. =3D issues compared to the other examples:
Warner Losh imp at FreeBSD.org wrote on
Mon Nov 20 22:42:21 UTC 2017 :
Modified: head/stand/powerpc/boot1.chrp/Makefile
=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
--- head/stand/powerpc/boot1.chrp/Makefile Mon Nov 20 22:41:22 2017 =
(r326037)
+++ head/stand/powerpc/boot1.chrp/Makefile Mon Nov 20 22:42:17 2017 =
(r326038)
@@ -13,9 +13,7 @@ SRCS=3D boot1.c ashldi3.c syncicache.c
=20
MAN=3D
=20
-CFLAGS=3D -ffreestanding -msoft-float \
- -I${LDRSRC} -I${SYSDIR} -I${SASRC} \
- -D_STANDALONE
+CFLAGS=3D -I${LDRSRC} -I${SYSDIR} -I${SASRC} -D_STANDALONE
LDFLAGS=3D-nostdlib -static -Wl,-N
=20
.PATH: ${SYSDIR}/libkern ${SRCTOP}/lib/libc/powerpc/gen ${.CURDIR}
but the other files tend to use +=3D for at least CFLAGS. In
one case you converted an =3D into only using +=3D locally:
-CFLAGS=3D -ffreestanding \
- -I${.CURDIR} \
+CFLAGS+=3D -I${.CURDIR} \
(Generally the mix seems to be as it was before
the changes but it likely looked odd before the
changes when the files were view together.)
There are also examples like:
LDFLAGS=3D -nostdlib -static -T =
${.CURDIR}/ldscript.${MACHINE_CPUARCH}
LDFLAGS+=3D -Wl,-znotext
and others with just =3D . But some files seem to always
use +=3D for LDFLAGS.
May be a round of =3D vs. +=3D checking is appropriate
for the involved files?
=3D=3D=3D
Mark Millard
markmi at dsl-only.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2434FC04-1FF3-48B0-8743-78412673616F>