Date: Wed, 28 Jul 2021 12:37:25 -0400 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Kevin Bowling <kbowling@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 7045b1603bdf - main - socket: Implement SO_RERROR Message-ID: <20210728163725.6qzqbvwynoeua2jo@mutt-hbsd> In-Reply-To: <202107281635.16SGZHdx081512@gitrepo.freebsd.org> References: <202107281635.16SGZHdx081512@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--inqfsygufoaszgwn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 28, 2021 at 04:35:17PM +0000, Kevin Bowling wrote: > The branch main has been updated by kbowling (ports committer): >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D7045b1603bdf054145dd958a4a= cc17b410fb62a0 >=20 > commit 7045b1603bdf054145dd958a4acc17b410fb62a0 > Author: Roy Marples <roy@marples.name> > AuthorDate: 2021-07-28 15:46:59 +0000 > Commit: Kevin Bowling <kbowling@FreeBSD.org> > CommitDate: 2021-07-28 16:35:09 +0000 >=20 > socket: Implement SO_RERROR > =20 > SO_RERROR indicates that receive buffer overflows should be handled as > errors. Historically receive buffer overflows have been ignored and > programs could not tell if they missed messages or messages had been > truncated because of overflows. Since programs historically do not > expect to get receive overflow errors, this behavior is not the > default. > =20 > This is really really important for programs that use route(4) to keep > in sync with the system. If we loose a message then we need to reload > the full system state, otherwise the behaviour from that point is > undefined and can lead to chasing bogus bug reports. > =20 > Reviewed by: philip (network), kbowling (transport), gbe (manpages) > MFC after: 2 weeks > Differential Revision: https://reviews.freebsd.org/D26652 > --- > lib/libc/sys/getsockopt.2 | 10 +++++++- > sbin/route/route.c | 13 +++++++++- > sys/kern/uipc_sockbuf.c | 24 +++++++++++++++++ > sys/kern/uipc_socket.c | 30 ++++++++++++++++= ------ > sys/kern/uipc_usrreq.c | 2 +- > sys/net/raw_usrreq.c | 11 ++++---- > .../bluetooth/socket/ng_btsocket_hci_raw.c | 1 + > sys/netgraph/ng_socket.c | 2 +- > sys/netinet/ip_divert.c | 2 +- > sys/netinet/ip_mroute.c | 2 +- > sys/netinet/raw_ip.c | 3 +-- > sys/netinet/udp_usrreq.c | 2 +- > sys/netinet6/icmp6.c | 6 ++--- > sys/netinet6/ip6_input.c | 1 + > sys/netinet6/ip6_mroute.c | 3 ++- > sys/netinet6/raw_ip6.c | 2 ++ > sys/netinet6/send.c | 2 +- > sys/netinet6/udp6_usrreq.c | 2 +- > sys/netipsec/keysock.c | 10 ++++---- > sys/sys/socket.h | 1 + > sys/sys/socketvar.h | 6 ++++- > 21 files changed, 100 insertions(+), 35 deletions(-) Hey Kevin, Would this commit be a good candidate for bumping __FreeBSD_version? Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --inqfsygufoaszgwn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmEBh8IACgkQ/y5nonf4 4fqpvw//eEP0BDGwrWTi2EsPmYDFiffnKkMiKBn30pXgOsyLyFdu1fUkiLQ8BH7n 3P0hNidpIGparuBwdgf34S2tOuz9ZW6iMmvc/RXq3D/lfl9t7wLowfZkAhzXq1zu lt4uxt7jM82LuZ+n1401eHKlnszVHO0bXJ7DMmc8xa8TFy9caAevvWoszCIYxayX LJZ10C4fws56DchCFZyJ8cG3iPwsDuqvLsSIIxhzHtxNKaALPzg/0HwlfRn7xOGN wuj+w2O1CUos/t7Z5732PbsNvYWr6955+msm14CbW5hfzcDGlMt4H7Zf0bpoQTwZ BJlnu3nwgUwvJ4yiLUq/fYnkajqcgRG844vuU0Gdpn5wo38BU3kGNCBpT/z0FlPW nxox1+LKDeMqi7Eh9lxzy6rUeiivsCL9K/4/yyzp2B2RM8E/7fr0uv3wX1MmLe/i YgRglWUmCDEs6XHuUh5YesDyBwpxoZxNcqsRMN5QIEAcyCe+O4eNsLaOuz9CFLvB o8ZjW18twwX70EQF0fNm2tygseQftELJBalAFhg5lTpniunRj5LbWFMgFivvXsAt UHHeS9X1fX8mvCP0XsFKfE53TzymwE+lmCvmF6g2Epeyc0LCkHmIeh2u5iIGICIU lB1czd85/Xp5X7nVDdsbMaW6ltpmLNm8vbwXLuhfpErA1ORDWzU= =EiqY -----END PGP SIGNATURE----- --inqfsygufoaszgwn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210728163725.6qzqbvwynoeua2jo>