Date: Sun, 25 Oct 2015 15:00:25 +0000 From: David Chisnall <theraven@FreeBSD.org> To: George Abdelmalik <gabdelmalik@uniridge.com.au> Cc: Ian Lepore <ian@FreeBSD.org>, freebsd-current@freebsd.org Subject: Re: dtc(1): reproducible segmentation fault Message-ID: <BC88C0CA-E418-4588-A37A-DD67C8780729@FreeBSD.org> In-Reply-To: <20151024230750.GB5266@barney.uniridge.com.au> References: <562A3FE5.8020809@uniridge.com.au> <F6FF4D7B-C380-4410-8A4D-6E376DF76C7D@gmail.com> <1445618437.91534.13.camel@freebsd.org> <2D772151-85F9-4D80-8074-58CD11FFF778@FreeBSD.org> <DC171BE3-F6BF-4103-BFB6-F08E8FE4A055@FreeBSD.org> <20151024230750.GB5266@barney.uniridge.com.au>
index | next in thread | previous in thread | raw e-mail
On 25 Oct 2015, at 00:07, George Abdelmalik <gabdelmalik@uniridge.com.au> wrote: > > You've beaten me to it with the fix before I could lodge the bug report :) > > In your repo I've seen that the mmap(2) call now takes the MAP_PRIVATE flag. I > applied that change locally to my source tree and that has fixed the problem. > I've since re-read the mmap(2) man page to find out how that change could > be influential... > > [EINVAL] None of MAP_ANON, MAP_PRIVATE, MAP_SHARED, or > MAP_STACK was specified. At least one of these flags > must be included. > > Although obvious to me now, I missed it on my previous reads. > > Thanks for your assistance. I look forward to your coming set of changes. In > my view DTC is an important tool and I would be willing contribute effort to > making it feature parity with the GPL version if that is lacking. It’s now committed (r289935). Sorry for the delay - I meant to commit the changes in January and it slipped down my to-do list. Please do test with any dts files that you have. If you find bugs, then please report them and assign them to me. Davidhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BC88C0CA-E418-4588-A37A-DD67C8780729>