Date: Sun, 23 Apr 2006 19:00:06 -0400 From: Alexander Kabaev <kabaev@gmail.com> To: John Birrell <jb@FreeBSD.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 95947 for review Message-ID: <20060423190006.4b9a1587@kan.dnsalias.net> In-Reply-To: <200604232039.k3NKdqvq057837@repoman.freebsd.org> References: <200604232039.k3NKdqvq057837@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sun, 23 Apr 2006 20:39:52 GMT John Birrell <jb@FreeBSD.org> wrote: > http://perforce.freebsd.org/chv.cgi?CH=95947 > > Change 95947 by jb@jb_freebsd2 on 2006/04/23 20:39:34 > > Go back to just using the /dev/dtrace device name and clone > from that name explicitly. > > Add a (temporary) debug flag for the device flags so that I > can sort out what each device is doing in the kernel. > > Affected files ... > > .. //depot/projects/dtrace/src/contrib/opensolaris/lib/libdtrace/common/dt_open.c#8 > edit .. //depot/projects/dtrace/src/sys/sys/fcntl.h#2 edit > > Differences ... > > ==== //depot/projects/dtrace/src/contrib/opensolaris/lib/libdtrace/common/dt_open.c#8 > (text) ==== > > @@ -922,7 +922,7 @@ > #if defined(sun) > dtfd = open("/dev/dtrace/dtrace", O_RDWR); > #else > - dtfd = open("/dev/dtrace0", O_RDWR); > + dtfd = open("/dev/dtrace", O_RDWR | O_DEBUG); > #endif > err = errno; /* save errno from opening dtfd */ > > > ==== //depot/projects/dtrace/src/sys/sys/fcntl.h#2 (text+ko) ==== > > @@ -113,6 +113,7 @@ > /* Attempt to bypass buffer cache */ > #define O_DIRECT 0x00010000 > #endif > +#define O_DEBUG 0x00020000 > > /* > * XXX missing O_DSYNC, O_RSYNC. Nothing stops you from recognizing names with slashes in your clone event handler, so this defined(sun) is probably unnecessary. -- Alexander Kabaev [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (FreeBSD) iD8DBQFETAb/Q6z1jMm+XZYRAt+fAJ9xVUik8tKibuMVG4rud67sgRYzvwCgoHUB /m7KnXZyT4JmlzfpcM0fIMs= =2El4 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060423190006.4b9a1587>