Date: Mon, 5 Dec 2005 12:32:20 +0000 (UTC) From: Marius Strobl <marius@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/dc if_dc.c Message-ID: <200512051232.jB5CWLP3015822@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
marius 2005-12-05 12:32:20 UTC
FreeBSD src repository
Modified files:
sys/dev/dc if_dc.c
Log:
- Rev. 1.175 fixed compilation on sparc64 but also backed out zeroing of
the eaddr array (introduced in rev. 1.174) prior to writing to it. As
dc_read_eeprom() is told to write only 3 16-bit words to eaddr but eaddr
in fact is somewhat larger removal of the zeroing defeated the check
whether the MAC address is all zero as there can be some random garbage
in eaddr past the 3 words written to it and the check verifys all bits
in eaddr. Solve this by changing the check to verify only the 3 words
(happenning to be ETHER_ADDR_LEN bytes) written to eaddr.
- While here change the notation of "FCode" in a nearby comment to the
official way.
Ok'ed by: marcel, ru
Revision Changes Path
1.176 +2 -5 src/sys/dev/dc/if_dc.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200512051232.jB5CWLP3015822>