Date: Tue, 12 Feb 2002 10:36:47 -0700 (MST) From: "M. Warner Losh" <imp@village.org> To: grog@FreeBSD.org Cc: joe@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb usbdi.c Message-ID: <20020212.103647.55833195.imp@village.org> In-Reply-To: <20020212073707.N670@sydney.worldwide.lemis.com> References: <200202111009.g1BA9UP67888@freefall.freebsd.org> <20020212073707.N670@sydney.worldwide.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20020212073707.N670@sydney.worldwide.lemis.com>
Greg Lehey <grog@FreeBSD.org> writes:
: On Monday, 11 February 2002 at 2:09:30 -0800, Josef Karthauser wrote:
: > joe 2002/02/11 02:09:30 PST
: >
: > Modified files:
: > sys/dev/usb usbdi.c
: > Log:
: > Merge from NetBSD: revs 1.89 and 1.90.
: >
: > Also, add some 'const's to supress warnings. (Submitted back to NetBSD).
: >
: > The original logs from NetBSD:
: >
: > ----------------------------
: > revision 1.90
: > date: 2001/12/03 01:47:12; author: augustss; lines: +4 -4
: > Handle vendor/product lookup with a common routine.
: > ----------------------------
: > revision 1.89
: > date: 2001/12/02 23:25:25; author: augustss; lines: +18 -2
: > Add a subroutine to search for a vendor/product pair.
: > ----------------------------
:
: I like this form of log message. What do other people think?
I think it is a little too long for my tastes, which is why I tend to
do it like so:
Catch up to NetBSD:
1.156 pooka; Socket Low-Power CF WLAN
1.155 ichiro; IBM Smart Capture Card II
1.152-154 ichiro; Fujitsu CF EtherCard and FMV-181,182,182A
1.151 christos; Symbol Spectrum24
which gives people a pointer to NetBSD to look at the detailed log
messages, gives proper credit to the folks on NetBSD that did the
commit and saves us from having N useless ----- lines. :-)
However, I don't object to it if someone wants to do it.
Warner
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020212.103647.55833195.imp>