Date: Tue, 25 Nov 2025 08:46:09 +0000 From: Ruslan Bukin <br@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: b87f6330013f - main - nvme(4): Increase HMB alignment. Message-ID: <69256cd1.2d876.36d668be@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by br: URL: https://cgit.FreeBSD.org/src/commit/?id=b87f6330013f2d04ef83c453f95db5cd3247e6e1 commit b87f6330013f2d04ef83c453f95db5cd3247e6e1 Author: Ruslan Bukin <br@FreeBSD.org> AuthorDate: 2025-11-25 08:38:37 +0000 Commit: Ruslan Bukin <br@FreeBSD.org> CommitDate: 2025-11-25 08:38:37 +0000 nvme(4): Increase HMB alignment. The NVME controller in Crucial P310 disk does not accept 16-byte aligned host memory buffer on Codasip Prime platform, but works fine on PAGE_SIZE aligned memory. Instead of adding a quirk, just increase alignment for everyone. Reviewed by: jhb Discussed with: imp Sponsored by: CHERI Research Centre Differential Revision: https://reviews.freebsd.org/D53296 --- sys/dev/nvme/nvme_ctrlr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/nvme/nvme_ctrlr.c b/sys/dev/nvme/nvme_ctrlr.c index 41542d24c107..1ad4735cbef8 100644 --- a/sys/dev/nvme/nvme_ctrlr.c +++ b/sys/dev/nvme/nvme_ctrlr.c @@ -907,7 +907,7 @@ again: size = sizeof(struct nvme_hmb_desc) * ctrlr->hmb_nchunks; err = bus_dma_tag_create(bus_get_dma_tag(ctrlr->dev), - 16, 0, BUS_SPACE_MAXADDR, BUS_SPACE_MAXADDR, NULL, NULL, + PAGE_SIZE, 0, BUS_SPACE_MAXADDR, BUS_SPACE_MAXADDR, NULL, NULL, size, 1, size, 0, NULL, NULL, &ctrlr->hmb_desc_tag); if (err != 0) { nvme_printf(ctrlr, "HMB desc tag create failed %d\n", err);help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69256cd1.2d876.36d668be>