Date: Sat, 28 Aug 2010 00:34:22 +0000 (UTC) From: Pyun YongHyeon <yongari@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/dev/e1000 if_em.c if_em.h if_igb.c if_igb.h if_lem.c if_lem.h src/sys/dev/ixgb if_ixgb.c if_ixgb.h src/sys/dev/ixgbe ixgbe.c ixgbe.h Message-ID: <201008280034.o7S0Yf1m077750@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
yongari 2010-08-28 00:34:22 UTC
FreeBSD src repository
Modified files:
sys/dev/e1000 if_em.c if_em.h if_igb.c if_igb.h
if_lem.c if_lem.h
sys/dev/ixgb if_ixgb.c if_ixgb.h
sys/dev/ixgbe ixgbe.c ixgbe.h
Log:
SVN rev 211913 on 2010-08-28 00:34:22Z by yongari
Do not allocate multicast array memory in multicast filter
configuration function. For failed memory allocations, em(4)/lem(4)
called panic(9) which is not acceptable on production box.
igb(4)/ixgb(4)/ix(4) allocated the required memory in stack which
consumed 768 bytes of stack memory which looks too big.
To address these issues, allocate multicast array memory in device
attach time and make multicast configuration success under any
conditions. This change also removes the excessive use of memory in
stack.
Reviewed by: jfv
Revision Changes Path
1.54 +14 -8 src/sys/dev/e1000/if_em.c
1.15 +2 -0 src/sys/dev/e1000/if_em.h
1.58 +16 -1 src/sys/dev/e1000/if_igb.c
1.15 +2 -0 src/sys/dev/e1000/if_igb.h
1.9 +14 -8 src/sys/dev/e1000/if_lem.c
1.3 +2 -0 src/sys/dev/e1000/if_lem.h
1.29 +16 -1 src/sys/dev/ixgb/if_ixgb.c
1.12 +2 -0 src/sys/dev/ixgb/if_ixgb.h
1.38 +16 -1 src/sys/dev/ixgbe/ixgbe.c
1.18 +2 -0 src/sys/dev/ixgbe/ixgbe.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201008280034.o7S0Yf1m077750>