Date: Tue, 15 Dec 2020 11:39:34 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Mark Johnston <markj@freebsd.org>, Hans Petter Selasky <hps@selasky.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r368523 - head/sys/vm Message-ID: <c111f8a6-375f-4798-12d7-24043aa90277@FreeBSD.org> In-Reply-To: <X9jQY6SLzEKznoex@raichu> References: <202012102044.0BAKiTHh011767@repo.freebsd.org> <a5b983ca-73f6-a7eb-7b96-bb361c1a8514@selasky.org> <X9jH20xQcS72vuDQ@raichu> <d4c78af3-e5c0-417f-1042-a0a7cf27d523@selasky.org> <X9jQY6SLzEKznoex@raichu>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--gnRroaiJmggqThfUt1wReLq4WxTTUkNY3
Content-Type: multipart/mixed; boundary="G8bN0TsR2GXK9oUy9Q6kXg4Wjb3qgftFo";
protected-headers="v1"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Mark Johnston <markj@freebsd.org>, Hans Petter Selasky <hps@selasky.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
svn-src-head@freebsd.org
Message-ID: <c111f8a6-375f-4798-12d7-24043aa90277@FreeBSD.org>
Subject: Re: svn commit: r368523 - head/sys/vm
References: <202012102044.0BAKiTHh011767@repo.freebsd.org>
<a5b983ca-73f6-a7eb-7b96-bb361c1a8514@selasky.org> <X9jH20xQcS72vuDQ@raichu>
<d4c78af3-e5c0-417f-1042-a0a7cf27d523@selasky.org> <X9jQY6SLzEKznoex@raichu>
In-Reply-To: <X9jQY6SLzEKznoex@raichu>
--G8bN0TsR2GXK9oUy9Q6kXg4Wjb3qgftFo
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
On 12/15/2020 7:04 AM, Mark Johnston wrote:
> On Tue, Dec 15, 2020 at 03:33:09PM +0100, Hans Petter Selasky wrote:
>> On 12/15/20 3:27 PM, Mark Johnston wrote:
>>>> I'm seeing the following panic:
>>>>
>>>> panic("vm_wait in early boot")
>>>> vm_wait_domain()
>>>> kmem_alloc_contig_pages()
>>>> kmem_alloc_contig_domainset()
>>>> kmem_alloc_contig()
>>>> contigmalloc()
>>>> x86bios_alloc()
>>>> vesa_configure()
>>>> vesa_mod_event()
>>>> vesa_module_register_init()
>>>> mi_startup()
>>> Is it on a NUMA system? I see that the new logic won't work properly=
if
>>> there are empty domains, so this suggests that we really do need a
>>> special contig iterator as discussed in the review.
>>
>> Yes, this is a numa system.
>>
>> I just noticed, that before r368523 "flags" was updated by=20
>> _vm_domainset_iter_policy_init() to always contain M_NOWAIT and that=20
>> avoids the wait logic, but I think x86bios_alloc() doesn't get its=20
>> memory then.
>=20
> Yes, but note that vm_domainset_iter_policy() will also call
> vm_wait_doms() if a M_NOWAIT allocation from each domain fails.
> x86bios_alloc() requests memory from the first 1MB of physical memory,
> but because contigmalloc() uses a round-robin iterator initialized from=
> per-thread state it may try from the "wrong" domain first. So really a=
> different solution to the original problem is needed.
>=20
>> I'm not sure if x86bios_alloc() needs to be attached a bit later anywa=
y?
>>
>> --HPS
I have reverted the change in r368673 until we come up with a more
comprehensive fix.
--=20
Regards,
Bryan Drewery
--G8bN0TsR2GXK9oUy9Q6kXg4Wjb3qgftFo--
--gnRroaiJmggqThfUt1wReLq4WxTTUkNY3
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"
-----BEGIN PGP SIGNATURE-----
wsB5BAABCAAjFiEE+Rc8ssOq6npcih8JNddxu25Gl88FAl/ZEPYFAwAAAAAACgkQNddxu25Gl899
gggA0dD7mNfQlb3+ZZ4PKtn2Vt+H1gPQaXG6ZQDQgjnopUOiFDJVKSZhs93RZM4n3B7zcjLn4aND
IcETuRAy/kmktwTgJfQRyWxyqOodI8KDEmyltBTg90GIqspF7bHwaamHMa63iQwwJ4Yerm03jOC2
gLlAhQ7wN1PzDZJoaS5rWt0STCSKoH7qoGAnUv2eoJl2N7vv4tNZej5Q1p06rFCqjZEN5WNNMT6H
ei0q9H4lW9KNLznHlHWOj7KY2sIzYVCBjMU/L6E8FdVuwHeLvlzREfeRypVNBIbJRkA5zzZ4cfnB
Aycs4oZcLsAN0cxIrRXrY4S6yR/wGJ/070K5IqTxYg==
=pxKg
-----END PGP SIGNATURE-----
--gnRroaiJmggqThfUt1wReLq4WxTTUkNY3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c111f8a6-375f-4798-12d7-24043aa90277>