Date: Fri, 06 Sep 2019 20:24:04 +0000 From: bugzilla-noreply@freebsd.org To: numerics@FreeBSD.org Subject: [Bug 240295] math(3): Add Complex Arithmetic functions and their hyperbolic counterparts Message-ID: <bug-240295-18636-vfXuEwqYxH@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-240295-18636@https.bugs.freebsd.org/bugzilla/> References: <bug-240295-18636@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240295 --- Comment #9 from Steve Kargl <kargl@FreeBSD.org> --- (In reply to Gordon Bergling from comment #8) > > I hope this was good for you, and you were able to direct all your anger, > fear and uncertainty towards this problem report. > > For my perspective, I just saw at [1] that there is an unresolved > issue with FreeBSD's math(3) implementation and I thought, that > this could be solved by stepping a few steps backwards and looking > at what the other BSDs have done to overcome that issue. There is no anger, fear, or uncertainty in my response. More likely disillusionment in that it seems that you=20 have made no effort to review the freebsd-numerics mailing list archive or what libm currently has implemented. Why does your patch have float complex and double complex versions of the functions? FreeBSD's libm has had those since 2011. ccos() already implement in src/s_ccosh.c * Copyright (c) 2005 Bruce D. Evans and Steven G. Kargl ccosf() already implement in src/s_ccoshf.c * Copyright (c) 2005 Bruce D. Evans and Steven G. Kargl (Yes, the Copyright year is correct as it is likely that some code came from other files hwne ccos and ccosf > The tickets I mentioned within my original ticket were open > for years Yeah, I know. I'm the person who filed those PRs. I'm also the only person for the last 20 years who has consistently=20 tried to fix FreeBSD libm to be C99 compliant with quality implementations. > and you are about to attacking the first person, who tries to > address that issues. I am quite sure that is not the spirit > what the FreeBSD project is about. You're not the first person, and you're not the first person who tries to grab code from one of the other BSDs as a solution without understanding some of the nuances of the floating point environment of FreeBSD. Did you actually test the functions? Here's a test for your ccoshl, and its wrong results ccoshl(-0,-inf) =3D (nan,nan) expecting (nan,+0) ccoshl(-0,+inf) =3D (nan,nan) expecting (nan,-0) ccoshl(+0,+nan) =3D (nan,nan) expecting (nan,+0) ccoshl(+0,-nan) =3D (nan,nan) expecting (nan,-0) ccoshl(-0,-nan) =3D (nan,nan) expecting (nan,+0) ccoshl(-0,+nan) =3D (nan,nan) expecting (nan,-0) ccoshl(+inf,+0) =3D (nan,nan) expecting (+inf,+0) ccoshl(+inf,-0) =3D (nan,nan) expecting (+inf,-0) ccoshl(-inf,-0) =3D (nan,nan) expecting (+inf,+0) ccoshl(-inf,+0) =3D (nan,nan) expecting (+inf,-0) ccoshl(+nan,+0) =3D (nan,nan) expecting (nan,+0) ccoshl(+nan,-0) =3D (nan,nan) expecting (nan,-0) ccoshl(-nan,-0) =3D (nan,nan) expecting (nan,+0) ccoshl(-nan,+0) =3D (nan,nan) expecting (nan,-0) ccoshl(+inf,+nan) =3D (nan,nan) expecting (+inf,nan) ccoshl(+inf,-nan) =3D (nan,nan) expecting (+inf,nan) ccoshl(-inf,-nan) =3D (nan,nan) expecting (+inf,nan) ccoshl(-inf,+nan) =3D (nan,nan) expecting (+inf,nan) ccoshl(+inf,+inf) =3D (nan,nan) expecting (+inf,nan) ccoshl(+inf,-inf) =3D (nan,nan) expecting (+inf,nan) ccoshl(-inf,-inf) =3D (nan,nan) expecting (+inf,nan) ccoshl(-inf,+inf) =3D (nan,nan) expecting (+inf,nan) ccoshl(+inf,1) =3D (nan,+inf) expecting (+inf*cos(y),+inf*sin(y)) ccoshl(-inf,1) =3D (nan,-inf) expecting (+inf*cos(y),-inf*sin(y)) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-240295-18636-vfXuEwqYxH>