Date: Mon, 6 Jan 2014 11:49:05 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r260363 - head/sys/dev/ath Message-ID: <CAJ-VmonDF1eAu7=gUNY50aQR0qqZvpCXSLho8GGQqVaTQwaRwQ@mail.gmail.com> In-Reply-To: <20140106173738.GG59496@kib.kiev.ua> References: <201401060348.s063mW8C031852@svn.freebsd.org> <20140106035139.GC59496@kib.kiev.ua> <CAJ-VmomRefeAdd_VdRO8Q8jTpC2hbC7Q22vy_uJB7FX=OUUFLQ@mail.gmail.com> <20140106173738.GG59496@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6 January 2014 09:37, Konstantin Belousov <kostikbel@gmail.com> wrote: >> > This is a NOP, right ? >> >> Nope. the previous version didn't remove the entries from the list. >> that's the bug. > Hm, you mean that the previous version did not TAILQ_INIT() after the loop ? > Then I agree. Well, it's that the frames just get moved between the RX queue active list(s) or the rxbuf inactive list. The correct thing to do is to TAILQ_REMOVE them from one list before adding them to the free list. -a
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmonDF1eAu7=gUNY50aQR0qqZvpCXSLho8GGQqVaTQwaRwQ>