Date: Mon, 24 Oct 2011 14:45:32 +0000 (UTC) From: Adrian Chadd <adrian@FreeBSD.org> To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r226692 - user/adrian/if_ath_tx/sys/dev/ath Message-ID: <201110241445.p9OEjWfe048468@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: adrian Date: Mon Oct 24 14:45:31 2011 New Revision: 226692 URL: http://svn.freebsd.org/changeset/base/226692 Log: Another thing fixed. Modified: user/adrian/if_ath_tx/sys/dev/ath/README Modified: user/adrian/if_ath_tx/sys/dev/ath/README ============================================================================== --- user/adrian/if_ath_tx/sys/dev/ath/README Mon Oct 24 14:37:26 2011 (r226691) +++ user/adrian/if_ath_tx/sys/dev/ath/README Mon Oct 24 14:45:31 2011 (r226692) @@ -68,16 +68,6 @@ wlan0: [00:1b:b1:58:f6:f0] discard dupli Things that need doing! ----------------------- -* The txactive bits are set in the interrupt handler context, and cleared - in the TX completion process context. Since TX interrupts may occur - during a TX completion process, it's unfortunately likely that this - will be very racey and end up missing perfectly valid TX events. - This should be resolved before things are merged into -HEAD. - - Maybe store the txqactive mask away in ath_softc and put the update - of said ath_softc version behind an atomic operation or lock. That way - the HAL doesn't have to change (for now). - * When off-channel, aggregate traffic should stay queued, but raw frames (eg probes) should be sent? @@ -467,3 +457,16 @@ pid 1510 newma does this too (check ath_pkt_duration()) - done - it uses the whole aggregate length, incl. delimiters. +* The txactive bits are set in the interrupt handler context, and cleared + in the TX completion process context. Since TX interrupts may occur + during a TX completion process, it's unfortunately likely that this + will be very racey and end up missing perfectly valid TX events. + This should be resolved before things are merged into -HEAD. + + Maybe store the txqactive mask away in ath_softc and put the update + of said ath_softc version behind an atomic operation or lock. That way + the HAL doesn't have to change (for now). + + - done - this is currently protected by ATH_LOCK and shadowed in the + ath_softc. +
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201110241445.p9OEjWfe048468>