Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 1 Oct 2001 13:01:08 -0700 (PDT)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   cvs commit: src/sys/kern vfs_syscalls.c
Message-ID:  <200110012001.f91K18B18115@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help 
rwatson     2001/10/01 13:01:08 PDT

  Modified files:
    sys/kern             vfs_syscalls.c 
  Log:
  o Complete the migration from suser error checking in the following form
    in vfs_syscalls.c:
  
      if (mp->mnt_stat.f_owner != p->p_ucred->cr_uid &&
          (error = suser_td(td)) != 0) {
              unwrap_lots_of_stuff();
              return (error);
      }
  
    to:
  
      if (mp->mnt_stat.f_owner != p->p_ucred->cr_uid) {
              error = suser_td(td);
              if (error) {
                  unwrap_lots_of_stuff();
                  return (error);
              }
      }
  
    This makes the code more readable when complex clauses are in use,
    and minimizes conflicts for large outstanding patchsets modifying the
    kernel authorization code (of which I have several), especially where
    existing authorization and context code are combined in the same if()
    conditional.
  
  Obtained from:	TrustedBSD Project
  
  Revision  Changes    Path
  1.207     +44 -23    src/sys/kern/vfs_syscalls.c


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200110012001.f91K18B18115>