Date: Tue, 26 Apr 2011 07:27:11 -0600 From: Warner Losh <imp@bsdimp.com> To: Gavin Atkinson <gavin@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, "David E. O'Brien" <obrien@FreeBSD.org> Subject: Re: svn commit: r221053 - head/usr.bin/rlogin Message-ID: <67269B04-5727-4B8D-B442-D93CD0CB0A61@bsdimp.com> In-Reply-To: <1303811835.49968.6.camel@buffy.york.ac.uk> References: <201104260409.p3Q49KaJ006272@svn.freebsd.org> <1303811835.49968.6.camel@buffy.york.ac.uk>
index | next in thread | previous in thread | raw e-mail
On Apr 26, 2011, at 3:57 AM, Gavin Atkinson wrote: > On Tue, 2011-04-26 at 04:09 +0000, David E. O'Brien wrote: >> Author: obrien >> Date: Tue Apr 26 04:09:20 2011 >> New Revision: 221053 >> URL: http://svn.freebsd.org/changeset/base/221053 >> >> Log: >> This builds OK using the parent dir's WARNS=6. >> [built on both AMD64 and i386] > > As a general rule, just compiling on i386 and amd64 are not sufficient > to test WARNS bumps. It's usually sufficient to also crossbuild to a > platform like sparc64 which has stricter alignment, but for a full test > a "make universe" is best, as this will also catch other issues (for > example arm, where char is unsigned). I read the test log as "not really tested, feel free to back it out if it fails on a different architecture" :) Warnerhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?67269B04-5727-4B8D-B442-D93CD0CB0A61>