Date: Fri, 6 Jun 2008 15:24:57 -0400 From: John Baldwin <jhb@freebsd.org> To: src-committers@freebsd.org Cc: cvs-src@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/smbus smb.c Message-ID: <200806061524.57417.jhb@freebsd.org> In-Reply-To: <200806061845.m56IjrsU075326@repoman.freebsd.org> References: <200806061845.m56IjrsU075326@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 06 June 2008 02:45:32 pm John Baldwin wrote: > jhb 2008-06-06 18:45:32 UTC > > FreeBSD src repository > > Modified files: > sys/dev/smbus smb.c > Log: > SVN rev 179625 on 2008-06-06 18:45:32Z by jhb > > - Store the device_t of the smbX device in the softc. > - Store the softc of the device in the 'si_drv1' of the cdev. > - Lookup the softc via 'si_drv1' in cdev methods rather than using the > minor number as a unit for devclass_get_softc(). > - Lookup the device_t via the softc field in cdev methods rather than > using the minor number as a unit for devclass_get_device(). > - Add a mutex to the softc to protect 'sc_opened'. > - Remove D_NEEDGIANT as all the smbus drivers are now MPSAFE and this driver > is now MPSAFE. > - Remove some checks for NULL softc pointers that can't happen and don't > bzero the softc during attach. All the smbus(4) stuff is MPSAFE now. I do plan to look at iic(4) soonish as it is similar in design to smbus(4). Once it is locked then if_ic(4) can be locked. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200806061524.57417.jhb>