Date: Wed, 12 May 1999 10:50:42 -0700 (PDT) From: Archie Cobbs <archie@whistle.com> To: beyssac@enst.fr (Pierre Beyssac) Cc: freebsd-current@FreeBSD.ORG Subject: Re: mbuf starvation Message-ID: <199905121750.KAA61736@bubba.whistle.com> In-Reply-To: <19990512172544.A440@enst.fr> from Pierre Beyssac at "May 12, 99 05:25:44 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
Pierre Beyssac writes:
> if (resid >= MINCLSIZE) {
> MCLGET(m, M_WAIT);
> + if (m == 0) {
> + error = ENOBUFS;
> + goto release;
> + }
> if ((m->m_flags & M_EXT) == 0)
> goto nopages;
> mlen = MCLBYTES;
I think this part of the patch is useless. MCLGET() does not set
m to NULL when it fails, it simply doesn't set the M_EXT flag.
...unless things have changed recently.
-Archie
___________________________________________________________________________
Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199905121750.KAA61736>