Date: Fri, 24 Dec 2004 19:28:11 +0100 From: Arjan Van Leeuwen <avleeuwen@gmail.com> To: Darren Reed <avalon@cairo.anu.edu.au> Cc: current@freebsd.org Subject: Re: IPFilter patched for SMP Message-ID: <d86b487304122410281bb55b8@mail.gmail.com> In-Reply-To: <200412240918.iBO9IRlo028138@cairo.anu.edu.au> References: <200412240918.iBO9IRlo028138@cairo.anu.edu.au>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Darren, On Fri, 24 Dec 2004 20:18:27 +1100 (EST), Darren Reed <avalon@cairo.anu.edu.au> wrote: > > I've just committed some changes to IPFilter in FreeBSD-current that > remove the "needs giant" flag and enables fine grained locking. > > I'd really like to hear back from anyone who can stress test this out > on a multi-cpu machine. The locking used is the same as for Solaris > and IRIX, so I'm relatively confident it shouldn't cause any deadlocks > but I'd still like to see it tested. Thanks, that's a nice christmas present! I'm getting some build errors though: cc -O2 -pipe -DUSE_INET6 -I/usr/src/sys/modules/ipfilter/../../contrib/ipfilter -DIPFILTER=1-DIPFILTER_LKM -DIPFILTER_LOG -DPFIL_HOOKS -D_KERNEL -DKLD_MODULE -nostdinc -I- -I/usr/src/sys/modules/ipfilter/../../contrib/ipfilter -include /usr/obj/usr/src/sys/VINCENT/opt_global.h -I. -I@ -I@/contrib/altq -I@/../include -finline-limit=8000 -fno-common -g -fno-omit-frame-pointer -I/usr/obj/usr/src/sys/VINCENT -mcmodel=kernel -mno-red-zone -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx -mno-3dnow -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -std=c99 -c /usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.c In file included from /usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.c:109: /usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.h:501:1: warning: "PFIL_HOOKS" redefined <command line>:6:1: warning: this is the location of the previous definition /usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.c: In function `fr_forgetifp': /usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.c:922: error: `ipf_mutex'undeclared (first use in this function) /usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.c:922: error: (Each undeclared identifier is reported only once /usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.c:922: error: for each function it appears in.) /usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.c: In function `ipfr_fastroute': /usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.c:1779: error: `ipf_rw' undeclared (first use in this function) *** Error code 1 Stop in /usr/src/sys/modules/ipfilter. *** Error code 1 Stop in /usr/src/sys/modules. *** Error code 1 Stop in /usr/obj/usr/src/sys/VINCENT. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. Arjan > > Merry Christmas, > Darren > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d86b487304122410281bb55b8>