Date: Tue, 20 Apr 2010 02:09:37 -0500 From: Alan Cox <alc@cs.rice.edu> To: kmacy@freebsd.org Cc: Alan Cox <alc@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r206140 - head/sys/vm Message-ID: <4BCD5331.4030303@cs.rice.edu> In-Reply-To: <x2m82c4140e1004192217s4562f8c7ze88026ec9316d6d6@mail.gmail.com> References: <201004031620.o33GKM0n037332@svn.freebsd.org> <x2m82c4140e1004192217s4562f8c7ze88026ec9316d6d6@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
K. Macy wrote: > How has the problem been addressed? I'm seeing periodic panics with > non-zero resident count with the page lock patch applied. It is > possible that I've inadvertently re-introduced an issue you've fixed. > > r196318 and r189783 come to mind. > > On Sat, Apr 3, 2010 at 9:20 AM, Alan Cox <alc@freebsd.org> wrote: > >> Author: alc >> Date: Sat Apr 3 16:20:22 2010 >> New Revision: 206140 >> URL: http://svn.freebsd.org/changeset/base/206140 >> >> Log: >> Re-enable the call to pmap_release() by vmspace_dofree(). The accounting >> problem that is described in the comment has been addressed. >> >> Submitted by: kib >> Tested by: pho (a few months ago) >> MFC after: 6 weeks >> >> Modified: >> head/sys/vm/vm_map.c >> >> Modified: head/sys/vm/vm_map.c >> ============================================================================== >> --- head/sys/vm/vm_map.c Sat Apr 3 15:52:32 2010 (r206139) >> +++ head/sys/vm/vm_map.c Sat Apr 3 16:20:22 2010 (r206140) >> @@ -313,6 +313,7 @@ vm_init2(void) >> static inline void >> vmspace_dofree(struct vmspace *vm) >> { >> + >> CTR1(KTR_VM, "vmspace_free: %p", vm); >> >> /* >> @@ -329,12 +330,8 @@ vmspace_dofree(struct vmspace *vm) >> (void)vm_map_remove(&vm->vm_map, vm->vm_map.min_offset, >> vm->vm_map.max_offset); >> >> - /* >> - * XXX Comment out the pmap_release call for now. The >> - * vmspace_zone is marked as UMA_ZONE_NOFREE, and bugs cause >> - * pmap.resident_count to be != 0 on exit sometimes. >> - */ >> -/* pmap_release(vmspace_pmap(vm)); */ >> + pmap_release(vmspace_pmap(vm)); >> + vm->vm_map.pmap = NULL; >> uma_zfree(vmspace_zone, vm); >> } >> >> >>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BCD5331.4030303>