Date: Tue, 26 Nov 2002 00:05:29 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: julian@elischer.org Cc: grog@FreeBSD.org, bde@zeta.org.au, julian@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/fsck_ffs pass5.c Message-ID: <20021126.000529.95577539.imp@bsdimp.com> In-Reply-To: <Pine.BSF.4.21.0211252225370.46897-100000@InterJet.elischer.org> References: <20021125.231623.131888344.imp@bsdimp.com> <Pine.BSF.4.21.0211252225370.46897-100000@InterJet.elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <Pine.BSF.4.21.0211252225370.46897-100000@InterJet.elischer.org>
Julian Elischer <julian@elischer.org> writes:
: All 3 had the parens. I think it makes it more readable. And you don't.
And neither does the rest of the file:
if (fs->fs_maxcontig < 2 && fs->fs_contigsumsize > 0) {
} else if (fs->fs_contigsumsize < fs->fs_maxcontig &&
fs->fs_contigsumsize < FS_MAXCONTIG) {
if (cursnapshot == 0 &&
memcmp(&newcg->cg_cs, cs, sizeof *cs) != 0 &&
dofix(&idesc[0], "FREE BLK COUNT(S) WRONG IN SUPERBLK")) {
if (cursnapshot == 0 &&
memcmp(newcg, cg, basesize) != 0 &&
dofix(&idesc[2], "SUMMARY INFORMATION BAD")) {
memmove(cg, newcg, (size_t)basesize);
if (bkgrdflag != 0 || usedsoftdep || debug) {
if (cursnapshot == 0 &&
memcmp(cg_inosused(newcg), cg_inosused(cg), mapsize) != 0 &&
dofix(&idesc[1], "BLK(S) MISSING IN BIT MAPS")) {
if (cursnapshot == 0 &&
memcmp(&cstotal, &fs->fs_cstotal, sizeof cstotal) != 0
&& dofix(&idesc[0], "SUMMARY BLK COUNT(S) WRONG IN SUPERBLK")) {
Every single other use in the file doesn't use parens. The closest
one is one case where they are really needed:
if ((j & l) == (k & l))
So I plan on making it consistant when the freeze lifts.
What's so hard about following the existing style? This is why the
rule was originally there.
Warner
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021126.000529.95577539.imp>