Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 3 May 2012 13:00:05 -0700
From:      Maksim Yevmenkin <maksim.yevmenkin@gmail.com>
To:        current@freebsd.org
Subject:   [patch]: RFC changing order for khelp modules
Message-ID:  <CAFPOs6oH8232zZKGWsneD1yNVjBmeSJDfVaPvOHFqHd5Aa0LDQ@mail.gmail.com>

next in thread | raw e-mail | index | archive | help
hello,

would anyone object to the following patch?

==

--- sys/module_khelp.h  (revision 582)
+++ sys/module_khelp.h  (working copy)
@@ -83,7 +83,7 @@
                .priv = &kmd_##hname                                    \
        };                                                              \
        DECLARE_MODULE(hname, h_##hname, SI_SUB_PROTO_IFATTACHDOMAIN,   \
-           SI_ORDER_ANY);                                              \
+           SI_ORDER_MIDDLE);                                           \
        MODULE_VERSION(hname, version)

 #define        KHELP_DECLARE_MOD_UMA(hname, hdata, hhooks, version,
size, ctor, dtor) \
@@ -102,7 +102,7 @@
                .priv = &kmd_##hname                                    \
        };                                                              \
        DECLARE_MODULE(hname, h_##hname, SI_SUB_PROTO_IFATTACHDOMAIN,   \
-           SI_ORDER_ANY);                                              \
+           SI_ORDER_MIDDLE);                                           \
        MODULE_VERSION(hname, version)


==

the issue i stumbled upon is that when i compile in all available tcp
congestion control algorithms into the kernel (instead of using them
as modules) a couple of those fail to initialize and register because
they fail to find h_ertt khelp module (which is also complied in)

thanks,
max



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFPOs6oH8232zZKGWsneD1yNVjBmeSJDfVaPvOHFqHd5Aa0LDQ>