Date: Tue, 25 Sep 2007 20:12:04 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Alan Cox <alc@cs.rice.edu> Cc: Alan Cox <alc@freebsd.org>, cvs-src@freebsd.org, Rink Springer <rink@freebsd.org>, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/include vmparam.h src/sys/arm/include vmparam.h src/sys/i386/include vmparam.h src/sys/ia64/include vmparam.h src/sys/kern kern_exec.c vfs_bio.c src/sys/powerpc/include vmparam.h src/sys/sparc64/include ... Message-ID: <20070925171204.GJ87366@deviant.kiev.zoral.com.ua> In-Reply-To: <46F93B16.50102@cs.rice.edu> References: <200709250625.l8P6P7w7082233@repoman.freebsd.org> <20070925110147.GC60963@rink.nu> <46F93B16.50102@cs.rice.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
--wA9WyeW1yVBM2Q32 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 25, 2007 at 11:45:10AM -0500, Alan Cox wrote: > Rink Springer wrote: > >Hi Alan, > > > >On Tue, Sep 25, 2007 at 06:25:07AM +0000, Alan Cox wrote: > > =20 > >> Change the management of cached pages (PQ_CACHE) in two fundamental > >> ways: > >> =20 > > > >With this change, KDE no longer starts up; the process 'kbuildsycoca' > >seems to wait forever in status 'madvpo'. Reverting this changeset fixes > >the problem. > > > > =20 >=20 > This is a problem with madvise(WILLNEED). I believe that the attached=20 > patch will fix it. >=20 > Thanks, > Alan >=20 >=20 >=20 > Index: vm/vm_object.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /home/ncvs/src/sys/vm/vm_object.c,v > retrieving revision 1.383 > diff -p -u -r1.383 vm_object.c > --- vm/vm_object.c 25 Sep 2007 06:25:06 -0000 1.383 > +++ vm/vm_object.c 25 Sep 2007 16:17:40 -0000 > @@ -1105,7 +1105,8 @@ shadowlookup: > /* > * If the page is cached, reactivate it. > */ > - m =3D vm_page_alloc(tobject, tpindex, VM_ALLOC_IFCACHED); > + m =3D vm_page_alloc(tobject, tpindex, VM_ALLOC_IFCACHED | > + VM_ALLOC_NOBUSY); > } > if (m =3D=3D NULL) { > /* Yes, this indeed fixes the problem. Several minutes ago I suggested the same change to rdivacky@, and he reported that the problem is gone. --wA9WyeW1yVBM2Q32 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFG+UFkC3+MBN1Mb4gRAtfIAKCrq7KDkSWp4X4XTK5ukM61V8XUhgCglu5h BaF1Wk3DLEFp2eqSsFM4Mps= =5eLU -----END PGP SIGNATURE----- --wA9WyeW1yVBM2Q32--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070925171204.GJ87366>