Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 12 Feb 2017 10:41:58 -0500
From:      "George Neville-Neil" <gnn@neville-neil.com>
To:        "Glen Barber" <gjb@FreeBSD.org>
Cc:        "Ermal =?utf-8?q?Lu=C3=A7i?=" <eri@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r313675 - in head/sys: netinet netinet6
Message-ID:  <53D3A92C-6C64-4C0C-A5E6-B659BFA139BF@neville-neil.com>
In-Reply-To: <20170212111045.GC13738@FreeBSD.org>
References:  <201702120656.v1C6uXp1008956@repo.freebsd.org> <20170212111045.GC13738@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 3156 and 4880).

--=_MailMate_399D2B93-4FB8-4736-9FAB-586EA5CE5549_=
Content-Type: text/plain; charset=utf-8; markup=markdown
Content-Transfer-Encoding: quoted-printable



On 12 Feb 2017, at 6:10, Glen Barber wrote:

> On Sun, Feb 12, 2017 at 06:56:33AM +0000, Ermal Lu=C3=A7i wrote:
>> Author: eri
>> Date: Sun Feb 12 06:56:33 2017
>> New Revision: 313675
>> URL: https://svnweb.freebsd.org/changeset/base/313675
>>
>> Log:
>>   Committed without approval from mentor.
>>
>>   Reported by:	gnn
>>
>
> What exactly does this mean?
>

Ermal took the Acceptance on reviews.freebsd.org by Adrian as an implicit=
 "go ahead" to commit to the tree.  The issue is that he's still under me=
ntorship, by me, and had not gotten an approval or had an Approved by: li=
ne.  I asked him to revert the change himself.

We're working out a few more issues in the review now.

Best,
George

--=_MailMate_399D2B93-4FB8-4736-9FAB-586EA5CE5549_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iEYEARECAAYFAliggkcACgkQYdh2wUQKM9LuOgCfbTTUz83s0WuLQLvudd+UvnPr
NfUAmwWaYVBc8oPnsEmZe8mK2sKuyLGe
=ixfM
-----END PGP SIGNATURE-----

--=_MailMate_399D2B93-4FB8-4736-9FAB-586EA5CE5549_=--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53D3A92C-6C64-4C0C-A5E6-B659BFA139BF>